feat: Adds argo server command. Fixes #1966
#1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Jan 14, 2020
|
|
||
| wfList, err := wfClient.ArgoprojV1alpha1().WorkflowTemplates(req.Namespace).List(v1.ListOptions{}) | ||
| options := v1.ListOptions{} | ||
| if req.ListOptions != nil { |
alexec
commented
Jan 14, 2020
| CGO_ENABLED=0 GOARCH=amd64 GOOS=windows go build -v -i -ldflags '${LDFLAGS}' -o dist/argo-windows-amd64 ./cmd/argo | ||
|
|
||
| .PHONY: cli-image | ||
| cli-image: dist/argo-linux-amd64 | ||
| # Create CLI image | ||
| ifeq ($(DEV_IMAGE),true) | ||
| cp dist/argo-linux-amd64 argo | ||
| docker build -t $(IMAGE_NAMESPACE)/argocli:$(IMAGE_TAG) --target argocli -f Dockerfile.dev. | ||
| docker build -t $(IMAGE_NAMESPACE)/argocli:$(IMAGE_TAG) --target argocli -f Dockerfile.dev . |
alexec
commented
Jan 14, 2020
test/e2e/fixtures/e2e_suite.go
Outdated
| @@ -191,7 +191,7 @@ func (s *E2ESuite) AfterTest(_, _ string) { | |||
|
|
|||
| func (s *E2ESuite) printDiagnostics() { | |||
| s.Diagnostics.Print() | |||
| wfs, err := s.wfClient.List(metav1.ListOptions{FieldSelector: "metadata.namespace=" + Namespace}) | |||
| wfs, err := s.wfClient.List(metav1.ListOptions{FieldSelector: "metadata.namespace=" + Namespace, LabelSelector: label}) | |||
There was a problem hiding this comment.
only print diagnostics for test subjects
alexec
commented
Jan 14, 2020
| @@ -16,7 +17,9 @@ type Diagnostics struct { | |||
| } | |||
|
|
|||
| func (d *Diagnostics) Logf(format string, args ...interface{}) { | |||
| d.Log(log.Fields{}, fmt.Sprintf(format, args...)) | |||
| for _, line := range strings.Split(fmt.Sprintf(format, args...), "\n") { | |||
There was a problem hiding this comment.
prints out HTTP chatter on multiple lines
alexec
changed the title
argo server command. Fixes #1966argo server command. Fixes #1966
Codecov Report
@@ Coverage Diff @@
## master #1972 +/- ##
=========================================
+ Coverage 8.88% 8.88% +<.01%
=========================================
Files 53 53
Lines 33608 33611 +3
=========================================
+ Hits 2985 2986 +1
- Misses 30233 30234 +1
- Partials 390 391 +1
Continue to review full report at Codecov.
|
simster7
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".