Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix UI TODOs #1987

Merged
merged 1 commit into from
Jan 15, 2020
Merged

chore: Fix UI TODOs #1987

merged 1 commit into from
Jan 15, 2020

Conversation

simster7
Copy link
Member

Fixes #1955

@simster7 simster7 mentioned this pull request Jan 15, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 15, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@14d5803). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1987   +/-   ##
========================================
  Coverage          ?   8.88%           
========================================
  Files             ?      53           
  Lines             ?   33608           
  Branches          ?       0           
========================================
  Hits              ?    2985           
  Misses            ?   30233           
  Partials          ?     390

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d5803...c814a08. Read the comment docs.

@simster7 simster7 requested a review from alexec January 15, 2020 20:22
alexec
alexec approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval.

ui/src/app/shared/utils.ts
@@ -92,5 +92,33 @@ export const Utils = {
} catch {
return null;
}
},

isNodeSuspended(node: models.NodeStatus): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of "util" or "common" files as they tend to get large and unwieldy. Could you create a separate file for this please?

@simster7 simster7 merged commit 27387d4 into argoproj:master Jan 15, 2020
@simster7 simster7 deleted the ui-todos-master branch January 15, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix UI TODOs
2 participants
@simster7 @alexec