chore: Fix UI TODOs #1967
Closed
chore: Fix UI TODOs #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexec
reviewed
Jan 14, 2020
| if (wf.spec.suspend !== undefined && wf.spec.suspend) { | ||
| return true; | ||
| } | ||
| if (wf.status && wf.status.nodes) { |
There was a problem hiding this comment.
so if any node is suspended - we are suspended?
alexec
approved these changes
Jan 14, 2020
Codecov Report
@@ Coverage Diff @@
## apiserverimpl #1967 +/- ##
=============================================
Coverage 8.88% 8.88%
=============================================
Files 53 53
Lines 33602 33602
=============================================
Hits 2984 2984
Misses 30229 30229
Partials 389 389Continue to review full report at Codecov.
|
|
Closed in favor of #1987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955