feat: Implemented open default browser in local mode #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
changed the title
alexec
reviewed
Jan 31, 2020
alexec
reviewed
Jan 31, 2020
alexec
reviewed
Jan 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #2122 +/- ##
=========================================
+ Coverage 11.69% 11.7% +0.01%
=========================================
Files 52 51 -1
Lines 26353 26321 -32
=========================================
Hits 3081 3081
+ Misses 22877 22845 -32
Partials 395 395
Continue to review full report at Codecov.
|
golangcibot
reviewed
Jan 31, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
golangcibot
reviewed
Jan 31, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
alexec
reviewed
Feb 1, 2020
| [[projects]] | ||
| branch = "master" | ||
| digest = "1:cf624c484f140dbeb3635c0410e9f444def176a9bcebde0facdef6be86a1dae4" | ||
| name = "github.com/skratchdot/open-golang" |
There was a problem hiding this comment.
yes. GPL and LGPL are not ok
alexec
requested changes
Feb 1, 2020
golangcibot
reviewed
Feb 3, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
golangcibot
reviewed
Feb 3, 2020
cmd/argo/commands/server.go
Outdated
| @@ -4,7 +4,8 @@ import ( | |||
| "fmt" | |||
| "os" | |||
| "time" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
File is not goimports-ed with -local github.com/argoproj/argo (from goimports)
alexec
reviewed
Feb 4, 2020
alexec
reviewed
Feb 4, 2020
alexec
reviewed
Feb 4, 2020
alexec
reviewed
Feb 4, 2020
alexec
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Open the Argo server page in browser when argo server starts in local mode #2120