feat: Implemented open default browser in local mode

cmd/argo/commands/server.go

@@ -12,6 +12,7 @@ import (
 	"golang.org/x/net/context"
 	"k8s.io/client-go/kubernetes"
 	_ "k8s.io/client-go/plugin/pkg/client/auth"
+	"github.com/skratchdot/open-golang/open"
 
 	"github.com/argoproj/argo/cmd/argo/commands/client"
 	wfclientset "github.com/argoproj/argo/pkg/client/clientset/versioned"
@@ -21,13 +22,14 @@ import (
 
 func NewServerCommand() *cobra.Command {
 	var (
-		logLevel         string // --loglevel
-		authMode         string
-		configMap        string
-		port             int
-		baseHRef         string
-		namespaced       bool   // --namespaced
-		managedNamespace string // --managed-namespace
+		logLevel           string // --loglevel
+		authMode           string
+		configMap          string
+		port               int
+		baseHRef           string
+		namespaced         bool   // --namespaced
+		managedNamespace   string // --managed-namespace
+		disableOpenBrowser bool
 	)
 
 	var command = cobra.Command{
@@ -87,7 +89,16 @@ See %s`, help.ArgoSever),
 			if err != nil {
 				return err
 			}
-			apiserver.NewArgoServer(opts).Run(ctx, port)
+			browserOpenFunc := func(url string) {}
+			if !disableOpenBrowser {
+				browserOpenFunc = func(url string) {
+					err := open.Run(url)
+					if err != nil {
+						log.Warnf("Unable to open the browser. %v", err)
+					}
+				}
+			}
+			apiserver.NewArgoServer(opts).Run(ctx, port, browserOpenFunc)
 			return nil
 		},
 	}
@@ -103,5 +114,6 @@ See %s`, help.ArgoSever),
 	command.Flags().StringVar(&logLevel, "loglevel", "info", "Set the logging level. One of: debug|info|warn|error")
 	command.Flags().BoolVar(&namespaced, "namespaced", false, "run as namespaced mode")
 	command.Flags().StringVar(&managedNamespace, "managed-namespace", "", "namespace that watches, default to the installation namespace")
+	command.Flags().BoolVar(&disableOpenBrowser, "disable-open-browser", false, "disable automatic launching of the browser [Hosted mode]")
 	return &command
 }

manifests/base/argo-server/argo-server-deployment.yaml

@@ -15,7 +15,7 @@ spec:
       containers:
         - name: argo-server
           image: argoproj/argocli:latest
-          args: [server]
+          args: ["server","--disable-open-browser"]
           ports:
             - containerPort: 2746
           readinessProbe:

manifests/install.yaml

@@ -348,6 +348,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         image: argoproj/argocli:latest
         name: argo-server
         ports:

manifests/namespace-install.yaml

@@ -255,6 +255,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         image: argoproj/argocli:latest
         name: argo-server

manifests/quick-start-mysql.yaml

@@ -369,6 +369,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         image: argoproj/argocli:latest
         name: argo-server

manifests/quick-start-no-db.yaml

@@ -327,6 +327,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         image: argoproj/argocli:latest
         name: argo-server

manifests/quick-start-postgres.yaml

@@ -369,6 +369,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         image: argoproj/argocli:latest
         name: argo-server

server/apiserver/argoserver.go

@@ -44,7 +44,9 @@ import (
 
 const (
 	// MaxGRPCMessageSize contains max grpc message size
-	MaxGRPCMessageSize = 100 * 1024 * 1024
+	MaxGRPCMessageSize   = 100 * 1024 * 1024
+	// Default listening host
+	DefaultListeningHost = "127.0.0.1"
 )
 
 type argoServer struct {
@@ -58,7 +60,7 @@ type argoServer struct {
 }
 
 type ArgoServerOpts struct {
-	BaseHRef         string
+	BaseHRef      string
 	Namespace     string
 	KubeClientset *kubernetes.Clientset
 	WfClientSet   *versioned.Clientset
@@ -105,7 +107,7 @@ func (ao ArgoServerOpts) ValidateOpts() error {
 	return nil
 }
 
-func (as *argoServer) Run(ctx context.Context, port int) {
+func (as *argoServer) Run(ctx context.Context, port int, browserOpenFunc func(string)) {
 
 	configMap, err := as.rsyncConfig()
 	if err != nil {
@@ -136,7 +138,7 @@ func (as *argoServer) Run(ctx context.Context, port int) {
 	// Start listener
 	var conn net.Listener
 	var listerErr error
-	address := fmt.Sprintf(":%d", port)
+	address := fmt.Sprintf("%s:%d", DefaultListeningHost, port)
 	err = wait.ExponentialBackoff(backoff, func() (bool, error) {
 		conn, listerErr = net.Listen("tcp", address)
 		if listerErr != nil {
@@ -158,7 +160,10 @@ func (as *argoServer) Run(ctx context.Context, port int) {
 	go func() { as.checkServeErr("grpcServer", grpcServer.Serve(grpcL)) }()
 	go func() { as.checkServeErr("httpServer", httpServer.Serve(httpL)) }()
 	go func() { as.checkServeErr("tcpm", tcpm.Serve()) }()
-	log.Infof("Argo Server started successfully on address %s", address)
+	log.Infof("Argo Server started successfully on address %s", conn.Addr().String())
+
+	browserOpenFunc("http://" + conn.Addr().String())
+
 	as.stopCh = make(chan struct{})
 	<-as.stopCh
 }

test/e2e/manifests/mysql.yaml

@@ -369,6 +369,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         - --auth-mode
         - client

test/e2e/manifests/no-db.yaml

@@ -327,6 +327,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         - --auth-mode
         - client

test/e2e/manifests/postgres.yaml

@@ -369,6 +369,7 @@ spec:
       containers:
       - args:
         - server
+        - --disable-open-browser
         - --namespaced
         - --auth-mode
         - client