Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'outputs.result' to Container templates #2584

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Apr 3, 2020

Closes #2530

@simster7 simster7 requested review from alexec and sarabala1979 April 3, 2020 16:54
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2584 into master will increase coverage by 0.02%.
The diff coverage is 41.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   11.14%   11.16%   +0.02%     
==========================================
  Files          83       83              
  Lines       32652    32673      +21     
==========================================
+ Hits         3640     3649       +9     
- Misses      28514    28525      +11     
- Partials      498      499       +1     
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0.00% <0.00%> (ø)
...rkflow/v1alpha1/cluster_workflow_template_types.go 0.00% <0.00%> (ø)
.../apis/workflow/v1alpha1/workflow_template_types.go 40.00% <0.00%> (ø)
pkg/apis/workflow/v1alpha1/workflow_types.go 10.90% <0.00%> (ø)
workflow/common/util.go 7.29% <0.00%> (ø)
workflow/controller/workflowpod.go 70.74% <ø> (ø)
workflow/executor/executor.go 4.37% <0.00%> (-0.04%) ⬇️
workflow/controller/dag.go 50.61% <33.33%> (ø)
workflow/controller/steps.go 64.89% <42.85%> (ø)
workflow/templateresolution/context.go 65.18% <48.93%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bc876...d9716a7. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Apr 6, 2020

@sarabala1979 I think your area?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{{steps.<STEPNAME>.outputs.result}} should work for container steps
4 participants