Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow template ref does not work in other namespace #3795

Merged
merged 14 commits into from
Aug 17, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.
    Fixed workflow template ref does not work in other namespace #3759

@sarabala1979 sarabala1979 marked this pull request as ready for review August 17, 2020 05:18
@sarabala1979 sarabala1979 requested a review from alexec August 17, 2020 05:18
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the same fix as #3779. I'll close that PR.

@alexec alexec linked an issue Aug 17, 2020 that may be closed by this pull request
@sarabala1979 sarabala1979 merged commit f15a8f7 into argoproj:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run workflows with workflow templates workflow template ref does not work in other namespace
2 participants