Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow template ref does not work in other namespace #3795

Merged
merged 14 commits into from
Aug 17, 2020
Merged

fix: workflow template ref does not work in other namespace #3795

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e663374
fix: DAG level Output Artifacts on K8S and Kubelet executor
sarabala1979 Jul 28, 2020
e5d78d4
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 28, 2020
e784e9d
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 29, 2020
a92c98d
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 31, 2020
d6456f6
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Jul 31, 2020
8020986
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 3, 2020
3a21a15
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 4, 2020
81149df
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 6, 2020
886e68b
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 11, 2020
e860842
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 12, 2020
461d03c
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 12, 2020
cbaa8ac
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 13, 2020
fc86b40
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Aug 17, 2020
f4dd4f8
fix: workflow template ref does not work in other namespace
sarabala1979 Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workflow/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func (wfc *WorkflowController) Run(ctx context.Context, wfWorkers, podWorkers in
log.Infof("Workers: workflow: %d, pod: %d", wfWorkers, podWorkers)

wfc.wfInformer = util.NewWorkflowInformer(wfc.restConfig, wfc.GetManagedNamespace(), workflowResyncPeriod, wfc.tweakListOptions)
wfc.wftmplInformer = informer.NewTolerantWorkflowTemplateInformer(wfc.dynamicInterface, workflowTemplateResyncPeriod, wfc.namespace)
wfc.wftmplInformer = informer.NewTolerantWorkflowTemplateInformer(wfc.dynamicInterface, workflowTemplateResyncPeriod, wfc.managedNamespace)

wfc.addWorkflowInformerHandlers()
wfc.podInformer = wfc.newPodInformer()
Expand Down