Tags: argoproj/argo-workflows
Tags
Merge commit from fork * fix(api): properly authorize GET workflow fallback to archive - the authorization was accidentally removed in f1ab5aa - also if no archived workflow is found, properly return the original error as per ac9e2de Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * test: add permission assertions for GET WF archived fallback - the permission suite seemed to not have previously tested this - add good, bad, and fake token checks - where "bad" is valid, but unauthorized, while "fake" is valid in format, but not corresponding to a real token Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * fix(test): assign `goodToken` initially - these tests were relying on ordering of assignments before, i.e. 1. good 2. bad 3. bad - should just assign before each test instead for simplicity / less complexity / less mistakes Signed-off-by: Anton Gilgur <agilgur5@gmail.com> --------- Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
Merge commit from fork * fix(api): properly authorize GET workflow fallback to archive - the authorization was accidentally removed in f1ab5aa - also if no archived workflow is found, properly return the original error as per ac9e2de Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * test: add permission assertions for GET WF archived fallback - the permission suite seemed to not have previously tested this - add good, bad, and fake token checks - where "bad" is valid, but unauthorized, while "fake" is valid in format, but not corresponding to a real token Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * fix(test): assign `goodToken` initially - these tests were relying on ordering of assignments before, i.e. 1. good 2. bad 3. bad - should just assign before each test instead for simplicity / less complexity / less mistakes Signed-off-by: Anton Gilgur <agilgur5@gmail.com> --------- Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
PreviousNext