Skip to content

Tags: argoproj/argo-workflows

Tags

v3.6.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Merge commit from fork

* fix(api): properly authorize GET workflow fallback to archive

- the authorization was accidentally removed in f1ab5aa

- also if no archived workflow is found, properly return the original error as per ac9e2de

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

* test: add permission assertions for GET WF archived fallback

- the permission suite seemed to not have previously tested this
- add good, bad, and fake token checks
  - where "bad" is valid, but unauthorized, while "fake" is valid in format, but not corresponding to a real token

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

* fix(test): assign `goodToken` initially

- these tests were relying on ordering of assignments before, i.e. 1. good 2. bad 3. bad
  - should just assign before each test instead for simplicity / less complexity / less mistakes

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

---------

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>

v3.5.13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Merge commit from fork

* fix(api): properly authorize GET workflow fallback to archive

- the authorization was accidentally removed in f1ab5aa

- also if no archived workflow is found, properly return the original error as per ac9e2de

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

* test: add permission assertions for GET WF archived fallback

- the permission suite seemed to not have previously tested this
- add good, bad, and fake token checks
  - where "bad" is valid, but unauthorized, while "fake" is valid in format, but not corresponding to a real token

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

* fix(test): assign `goodToken` initially

- these tests were relying on ordering of assignments before, i.e. 1. good 2. bad 3. bad
  - should just assign before each test instead for simplicity / less complexity / less mistakes

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

---------

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>

v3.6.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix: use templateName where possible else nothing (#13836)

Signed-off-by: isubasinghe <isitha@pipekit.io>

v3.6.0-rc4

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix: use templateName where possible else nothing (#13836)

Signed-off-by: isubasinghe <isitha@pipekit.io>

v3.5.12

fix: mark taskresult complete when failed or error. Fixes #12993, Fixes 

#13533 (#13798)

Signed-off-by: isubasinghe <isitha@pipekit.io>

v3.6.0-rc3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
docs: upgrading notes (postgres archive and `ARGO_TEMPLATE`) (#13803)

Signed-off-by: Alan Clucas <alan@clucas.org>

v3.4.18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix(ui): remove leading slash in `uiUrl` for ArchivedWorkflowList red…

…irect. Fixes #13056 (#13713)

Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>

v3.6.0-rc2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
docs: add Alibaba Cloud presentations from KubeCon China (#13689)

Signed-off-by: shuangkun <tsk2013uestc@163.com>

v3.5.11

Verified

This commit was signed with the committer’s verified signature.
Joibel Alan Clucas
chore: ui linter fixes

Signed-off-by: Alan Clucas <alan@clucas.org>

v3.6.0-rc1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix(semaphore): ensure `holderKey`s carry all information needed. Fixes 

#8684 (#13553)

Signed-off-by: isubasinghe <isitha@pipekit.io>