Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Adding integration tests for cv_task_v3 #631

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

Vibhu-gslab
Copy link
Collaborator

Change Summary

Adding integration tests for cv_task_v3

Related Issue(s)

Fixes #

Component(s) name

arista.cvp.cv_task_v3

How to test

molecule converge -s cv_task_v3

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@sugetha24
Copy link
Contributor

Can we follow the same format as the other molecule test and put the tests in a separate playbook and import them in converge.yml?

- "{{MOVE_DEVICE_DATA_EXECUTE.devices_moved.taskIds[0]}}"
register: EXECUTE_TASK_DATA

- name: Testing Execute Task
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the task facts from CVP and check if they got executed? and same for cancelled example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will complete this once PR #632 gets merged

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@github-actions github-actions bot requested a review from sugetha24 June 23, 2023 09:04
@Vibhu-gslab
Copy link
Collaborator Author

Vibhu-gslab commented Jun 23, 2023

Can we follow the same format as the other molecule test and put the tests in a separate playbook and import them in converge.yml?

Fixed!

@Vibhu-gslab Vibhu-gslab marked this pull request as draft June 23, 2023 09:08
@sugetha24 sugetha24 mentioned this pull request Jun 26, 2023
9 tasks
@sugetha24 sugetha24 force-pushed the cv_task_v3 branch 4 times, most recently from 5f5f921 to 12bcc1a Compare July 14, 2023 21:01
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in ATD, lgtm!

@sugetha24 sugetha24 marked this pull request as ready for review July 18, 2023 23:19
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review July 20, 2023 07:02
@sugetha24 sugetha24 merged commit 080bc78 into aristanetworks:devel Jul 20, 2023
22 checks passed
sugetha24 added a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants