Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added 'images', 'tasks' options and containers 'regexp_filter' in cv_facts_v3 with examples #632

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Feat: Added 'images', 'tasks' options and containers 'regexp_filter' in cv_facts_v3 with examples #632

merged 6 commits into from
Jul 14, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jun 8, 2023 •
edited
Loading

Change Summary

Added 'images' and 'tasks' options in cv_facts_v3 with examples

Component(s) name

arista.cvp.cv_facts_v3

Proposed changes

  1. Added images option to cv_facts_v3:
  • It collects facts for images present in CVP.
  • Filter by image_name can be applied by regexp_filter option, to get the specific image facts.
  1. Added tasks option to cv_facts_v3:
  • It collects facts for tasks present in CVP.
  • Filter by task_id and task_status can be applied by regexp_filter option, to get the specific task facts.
  • Verbose can be applied with verbose option to get long/short facts.
  1. Added regexp_filter for containers option in cv_facts_v3:
  • It filters the container facts by container name mentioned in regexp_filter argument.

How to test

Run the playbooks in examples/cv_facts_v3 directory

  • Follow the instruction on Readme to setup testing environment and follow instructions to run example playbooks

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added module: cv_facts_v3 module_utils: cv_client cv_client implementation issue labels Jun 8, 2023
@sugetha24
Copy link
Contributor

sugetha24 commented Jun 14, 2023 •
edited
Loading

Can we update Documentation for this?

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jun 15, 2023
@Shivani-chourasiya
Copy link
Contributor Author

Shivani-chourasiya commented Jun 15, 2023 •
edited
Loading

Can we update Documentation for this?

Updated the docs!

@github-actions github-actions bot requested a review from sugetha24 June 15, 2023 21:15
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft June 16, 2023 08:26
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review June 16, 2023 10:09
@Shivani-chourasiya Shivani-chourasiya changed the title Feat: Added 'images' and 'tasks' options in cv_facts_v3 with examples Feat: Added 'images', 'tasks' options and containers 'regexp_filter' in cv_facts_v3 with examples Jun 16, 2023
sugetha24
sugetha24 reviewed Jun 16, 2023
View reviewed changes
ansible_collections/arista/cvp/examples/cv_facts_v3/get_configlet_facts.yml Outdated
arista.cvp.cv_facts_v3:
facts:
- configlet
regexp_filter: 'cofiglet1' # collects specific configlet facts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you meant 'configlet1' ?

Copy link
Contributor Author

@Shivani-chourasiya Shivani-chourasiya Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its a typo..let me fix it right away

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@github-actions github-actions bot requested a review from sugetha24 June 16, 2023 17:44
@Shivani-chourasiya Shivani-chourasiya mentioned this pull request Jun 23, 2023
Merged
4 tasks
@Vibhu-gslab Vibhu-gslab mentioned this pull request Jun 23, 2023
Merged
4 tasks
tgodaA
tgodaA approved these changes Jun 23, 2023
View reviewed changes
Copy link

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from sugetha24 June 28, 2023 07:19
@sugetha24 sugetha24 force-pushed the cv_facts_v3_modified branch 2 times, most recently from d7a1de0 to f15161c Compare July 13, 2023 18:20
@sugetha24 sugetha24 merged commit b8354ff into aristanetworks:devel Jul 14, 2023
18 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@guillaumeVilar guillaumeVilar Awaiting requested review from guillaumeVilar

@noredistribution noredistribution Awaiting requested review from noredistribution

@sugetha24 sugetha24 Awaiting requested review from sugetha24

Assignees
No one assigned
Labels
module: cv_facts_v3 module_utils: cv_client cv_client implementation issue type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shivani-chourasiya @sugetha24 @tgodaA @Shivani-gslab