Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publication of ark-circom on crates.io #47

Closed
tyshko-rostyslav opened this issue Jun 23, 2023 · 13 comments
Closed

Publication of ark-circom on crates.io #47

tyshko-rostyslav opened this issue Jun 23, 2023 · 13 comments
Assignees
@tyshko-rostyslav

Comments

@tyshko-rostyslav
Copy link
Collaborator

The fact of ark-circom not being on crates.io blocks vacp2p/zerokit#99
@tyshko-rostyslav
Copy link
Collaborator Author

@gakonst Could you, please, help with this?

@gakonst
Copy link
Collaborator

gakonst commented Jul 2, 2023

I've passed on maintenance to @Pratyush & co., so they can take it over from here!

@Pratyush
Copy link
Member

Pratyush commented Jul 2, 2023

I’ll look into this over the next week! @gakonst you might have to give us access to publish on crates.io. (Though also happy to publish under a new name if that makes sense)

@gakonst
Copy link
Collaborator

gakonst commented Jul 2, 2023

It's not been published before on crates so feel free to do the first release under your acc.

@tyshko-rostyslav
Copy link
Collaborator Author

I’ll look into this over the next week! @gakonst you might have to give us access to publish on crates.io. (Though also happy to publish under a new name if that makes sense)

Hi, @Pratyush ! Any chance on this?

@tyshko-rostyslav
Copy link
Collaborator Author

#48

@tyshko-rostyslav
Copy link
Collaborator Author

@Pratyush @gakonst
I've prepared a PR that would make the crate ready for publication.
Could I ask you to make me a maintaner of this repo, to avoid loosing your time on such minor kind of issue, that though appear fairly rarely, are critical for our development?

@Pratyush
Copy link
Member

Done! Though #48 is currently failing tests.

@tyshko-rostyslav
Copy link
Collaborator Author

Done! Though #48 is currently failing tests.

Thanks!
It's failing, because master is failing

@tyshko-rostyslav
Copy link
Collaborator Author

Done! Though #48 is currently failing tests.

Hi, @Pratyush , could you, please take a look at #52 , it fixes current master branch failing ?

@tyshko-rostyslav
Copy link
Collaborator Author

Done! Though #48 is currently failing tests.

@Pratyush Since master is running fine now, I updated #48, and it's ready for review as well. Please, take a took, when you have a free minute

Pratyush pushed a commit that referenced this issue Jul 24, 2023
@tyshko-rostyslav @tyshkor
Preparatory work for issue #47 (#48)
5748133 
Co-authored-by: tyshkor <tyshko1@gmail.com>
@tyshko-rostyslav tyshko-rostyslav mentioned this issue Jul 25, 2023
Merged
@tyshko-rostyslav
Copy link
Collaborator Author

@Pratyush Could you, please, take a look at #54 as licence and description are necessary for crates io publication. The main question is if you are ok with the licence I chose

@tyshko-rostyslav tyshko-rostyslav self-assigned this Jul 26, 2023
@tyshko-rostyslav
Copy link
Collaborator Author

Thanks, everybody! I published the crate: https://crates.io/crates/ark-circom

chancehudson pushed a commit to chancehudson/circom-compat that referenced this issue Jun 12, 2024
@tyshko-rostyslav @chancehudson
Fix CI by fixing version + add toolchain file (arkworks-rs#52)
df8b875 
* Fix CI by fixing version + add toolchain file

* readme comment

* Tweak README message

* typo

---------

Co-authored-by: tyshkor <tyshko1@gmail.com>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>

Preparatory work for issue arkworks-rs#47 (arkworks-rs#48)

Co-authored-by: tyshkor <tyshko1@gmail.com>

description and licence (arkworks-rs#54)

comment out / delete irrelevant interface

put back circom1 functions which are actually used

rename Circom trait to Circom1

dont use safe memory for circom2

store prime on WitnessCalculator

memory module compiles

circom module compiles

tests pass

3.3

tests pass

pin url version

Tests pass

refactor sanity-check arg

update rustc ci

clippy warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyshko-rostyslav tyshko-rostyslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pratyush @gakonst @tyshko-rostyslav