Fix CI by fixing version + add toolchain file #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm were you able to figure out why there's a bug with using newer versions of Rust? |
@Pratyush Reason is misaligned pointers in |
|
Thanks for investigating this! so it looks like an upstream bug. In that case let's add a note to the README indicating that currently we're limited to 1.67, and file an issue to bring back support for standard stable once the upstream issue is fixed. |
Pratyush
reviewed
Jul 24, 2023
Pratyush
approved these changes
Jul 24, 2023
|
Thanks! Tweaked the README message, and now this LGTM =) |
chancehudson
pushed a commit
to chancehudson/circom-compat
that referenced
this pull request
Jun 12, 2024
* Fix CI by fixing version + add toolchain file * readme comment * Tweak README message * typo --------- Co-authored-by: tyshkor <tyshko1@gmail.com> Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> Preparatory work for issue arkworks-rs#47 (arkworks-rs#48) Co-authored-by: tyshkor <tyshko1@gmail.com> description and licence (arkworks-rs#54) comment out / delete irrelevant interface put back circom1 functions which are actually used rename Circom trait to Circom1 dont use safe memory for circom2 store prime on WitnessCalculator memory module compiles circom module compiles tests pass 3.3 tests pass pin url version Tests pass refactor sanity-check arg update rustc ci clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50