-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed initRemoteConfig method #824
Removed initRemoteConfig method #824
Conversation
Fixed misconception about inititalization/activation
@kurtsergey I feel this change should depend on a configuration variable so that it can be turned on/off based the the app's requirements. Some apps may depend on this functionality, so we can't just remove it entirely. |
@soumak77 Apps cannot depend on this functionality because there is no 'init' functionality in native RemoteConfig modules. |
@kurtsergey understood. Does this fix any open issues that can be closed once merged? |
No, I cannot find any issues about it. |
@soumak77 Would you please publish release? |
I will once #830 is tested and merged
…On Thu, Sep 6, 2018, 11:09 PM Sergey Kurchanov ***@***.***> wrote:
@soumak77 <https://github.com/soumak77> Would you please publish release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKZWK1vJG6vSdlzQDB7tAWh9jziD0B_hks5uYg2dgaJpZM4WaeNL>
.
|
I get RemoteConfig isn't initalised... Get the error when calling setConfigSettings(..) |
@herrskytte the analytics and performance inits are still in the latest version of the plugin. These were added by accident as they change the defualt behavior of this plugin. We are working on reverting the code so users don't have to call in init method. We have a pull request to remove them so if you could test and confirm if this resolves the issue, that would be great. You can do this by:
If you could test with that branch and confirm that it works as expected, that would help us in merging the fix faster. |
@briantq I am working behind a firewall, so I can only access Maven, not Github. Sorry. Sidenote: Yesterday I only got the error about RemoteConfig, but after resetting the platform the app now crashes on startup with a Java IllegalStateException: FirebaseApp is not initialized in this process .. Make sure to call FirebaseApp.initializeApp(Context) first. I get this both with and without the initX code |
@herrskytte Can you run |
Fixed misconception about inititalization/activation