Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring Firebase initialization on startup #830

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

briantq
Copy link
Contributor

@briantq briantq commented Sep 6, 2018

THIS IS UNTESTED

I worked off the PR #784 to add Crashlytics and change Firebase initialization to try to revert not initializing Firebase. I have not had a chance to test this, and unfortunately don't have an Android project I can even test this on, so definitely appreciate any help by installing the branch and see if it resolves the issue.

I wanted to get it out so people can test and make any suggestions on the code change. I will add a comment when I am able to test with iOS.

@briantq
Copy link
Contributor Author

briantq commented Sep 7, 2018

@bpdinteractive confirmed this appears to fix the messaging issue on Android. I tried it in my iOS app and it appears to be working. @soumak77 is there anyone else we should get to test/review this change?

@qswinson
Copy link

qswinson commented Sep 7, 2018

I have verified the pull request removes the need to call initFirebase for both iOS and Android however it does still require initAnalytics to be added if you want that feature enabled. I'm not sure if this is a breaking change from the previously released version but it was for the very old version I updated from (0.1.25).

@soumak77
Copy link
Contributor

soumak77 commented Sep 7, 2018

Seems tested enough to get merged. I'll release v1.1.4 with this fix once I get home later today.

@briantq
Copy link
Contributor Author

briantq commented Sep 17, 2018

@qswinson Nice to see a fellow Austinite :) The issue you were having with initAnalytics should be resolved in a different pull request and should be in v2.0.1. Please note, there is still an issue with the install of v2.0.1 on Android that that's an outstanding PR for, but it should be working on iOS fully. Let us know if you see something different

@briantq briantq deleted the init-rollback branch September 18, 2018 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants