Agents-transfers logging reports

[ross-spencer]

This finally completes an API endpoint and basic reports to list information about users and ingests for which they were responsible for. Delivering a tabular representation of that work and a prototype timeline using plotly express.

The API endpoint to access the data will be at:

• curl -X GET "http://127.0.0.1:5000/api/data/agents-transfers/1" -H "accept: application/json"

Prototype gantt

Table

The work leverages much of the testing efforts of Tessa so thank you for that! And also tries to comply with new efforts around base templates as well. Hopefully it's looking okay.

@peterVG we'd spoken before about what methods we might use to deliver charts and there might be some good exploration to do there. For this work the code that enables that is located in this commit which you might be interested in: d8cf25d

Connected to #18

[tw4l]

Hi @ross-spencer. This is looking great - nice work! I've left comments where I had questions or think there are some opportunities to tidy bits of the code up a bit, but overall it's already in good shape.

I'm wondering what the Gantt chart will look like for Storage Services that have been in production for months or years. Would the individual ingests still be visible and hoverable? It seems like the built-in plotly toolbar's zoom function would help but I suspect that might point to the need to add support for start/end date parameters in the near future. That said, I think it would be reasonable to do so in a follow-up PR, and as I pointed out offline my next PR will contain some helpers that might make that a bit simpler.

[ross-spencer]

Thanks Tessa - resubmitted for code review. Also noted offline, we're thinking we can improve the date handling around the plot chart sometime down the line using some of your new handlers. I'm looking forward to review those, and thanks again for the conversation around this.

[ross-spencer]

@tw4l there are a couple of commits on top of the first push here now - I noticed a broken endpoint (i broke it), and some documentation issues that it felt appropriate to fix. Sorry about that!

[tw4l]

@ross-spencer cool, thanks! I'm planning to finish up my review tomorrow morning.

[tw4l]

Hi @ross-spencer - this is looking great and I think we're very nearly there. In addition to my comment above about removing the FIELD_AIP constant (which is preventing some reports from loading properly for me), there are just two areas I think could use a little attention:

1. Linting is failing for AIPscan/Data/tests/test_agents_transfers.py when I run the tests via tox. I think it just needs black to be run on it.
2. Thank you for bringing the font-awesome assets in locally! There are a lot more files than I was expecting, and it's making it a bit hard to pick out our own JS and CSS files from the vendor ones. Would you mind seeing if we can group them together, maybe in a vendor/fontawesome subdirectory, or something like that? I recognize that we haven't done that for vendor assets yet, but it seems like this might be a good place to start with that. I'd also encourage seeing if we need all of these assets or whether a subset would suffice, but I'd understand if at this stage you'd rather put that time and effort elsewhere so please don't see that as a hard requirement.

(Edit: Added reference to FIELD_AIP constant issue)

[ross-spencer]

Should be good now @tw4l lmk!

[ross-spencer]

EDIT: You got me thinking about dates more and I spotted an issue with the query as a result so there are two other commits. They work like this:

1. Creates a failure condition in the tests.
2. Writes the fix to correct that.

Now I'm hoping this PR is looking good! 🤞

[tw4l]

Tests and linting are passing, code looks good, all issues resolved. LGTM! 👍 Good work too on updating the query and tests!