Add agents tables #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-spencer
force-pushed
the
dev/issue-18-add-data-to-agents-tables
branch
3 times, most recently
from
6a838a7 to
7dbf3fc
Compare
This was one of the last pieces of information missing from the METS extract.
ross-spencer
force-pushed
the
dev/issue-18-add-data-to-agents-tables
branch
from
7dbf3fc to
591a773
Compare
tw4l
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling the database specific work out of #65
Connected to #18
@tw4l following on from our convo, I think I managed to satisfy myself with this one after a rocky start this evening. There are some rudimentary tests, and I managed to organize my thinking around the
_internalfunctions so I think they're more logical. This might provide a good base to do the rest of the model refactor from. As mentioned, feel free to merge/amend and merge if it looks okay! 🤞