Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lint failures for Rust 1.75.0, relax trait bounds on impl IntoIterator for &SymbolTable #257

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jan 3, 2024

I'll prep a release after this is merged.

All of these existing `IntoIterator` impls did not include the generic
parameter for the `BuildHasher`, meaning the impl was overly (and
unnecessarily) restrictive.

Found by `clippy::iter_without_into_iter`. See rust-lang/rust-clippy#11692 (comment).
Fixes `clippy::unnecessary_fallible_conversions`. This is probably a
holdover from before that cfg block was in there.
@lopopolo lopopolo added I-bytes Interner: Byte string SymbolTable. C-bug Category: This is a bug. I-str Interner: UTF-8 string SymbolTable. C-quality Category: Refactoring, cleanup, and quality improvements. I-cstr Interner: C string SymbolTable. A-interner Area: String interners, data structures, and types. I-path Interner: Path string SymbolTable. I-platform Interner: OsStr (platform) string SymbolTable. labels Jan 3, 2024
@lopopolo lopopolo merged commit f0f01e0 into trunk Jan 3, 2024
25 checks passed
@lopopolo lopopolo deleted the lopopolo/rust-1.75-clippy branch January 3, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interner Area: String interners, data structures, and types. C-bug Category: This is a bug. C-quality Category: Refactoring, cleanup, and quality improvements. I-bytes Interner: Byte string SymbolTable. I-cstr Interner: C string SymbolTable. I-path Interner: Path string SymbolTable. I-platform Interner: OsStr (platform) string SymbolTable. I-str Interner: UTF-8 string SymbolTable.
Development

Successfully merging this pull request may close these issues.

1 participant