Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy lint failures for Rust 1.75.0, relax trait bounds on impl IntoIterator for &SymbolTable #257

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix clippy lint failures for Rust 1.75.0, relax trait bounds on impl IntoIterator for &SymbolTable #257

merged 2 commits into from
Jan 3, 2024
+7 −7

Commits on Jan 3, 2024

  1. Loosen the generic bound on impl IntoIterator for &SymbolTable 

    All of these existing `IntoIterator` impls did not include the generic
parameter for the `BuildHasher`, meaning the impl was overly (and
unnecessarily) restrictive.

Found by `clippy::iter_without_into_iter`. See rust-lang/rust-clippy#11692 (comment).
    @lopopolo
    lopopolo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6f8e2e4 View commit details
    Browse the repository at this point in the history

  2. Fix use of unnecessarily fallible conversion 

    Fixes `clippy::unnecessary_fallible_conversions`. This is probably a
holdover from before that cfg block was in there.
    @lopopolo
    lopopolo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a35f782 View commit details
    Browse the repository at this point in the history