Introduce abstraction for stream logging #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a wrapper class to put the logic for logging to an IO like object. This is to prevent having to put all the logic in the log.rb class itself based if it's a syslog instance or not. It updates the tests to account for this and also removes the now unused mutex code.
dbussink
commented
Aug 15, 2017
| @@ -130,7 +130,7 @@ def test_log_exception | |||
|
|
|||
| oneline_backtrace = @out.string.gsub("\n", 'XX') | |||
|
|
|||
| assert_match /test=exception at=exception.*test_log_exception.*XX.*minitest/, | |||
| assert_match /test=exception at=exception.*test_log_exception.*XX/, | |||
There was a problem hiding this comment.
This was needed to get the tests to pass since more recent Ruby versions don't run the tests with minitest by default anymore.
| @@ -231,21 +232,14 @@ def calc_time(start, finish) | |||
| ((finish - start).to_f * @t) | |||
| end | |||
|
|
|||
| def mtx | |||
| @mtx ||= Mutex.new | |||
| end | |||
There was a problem hiding this comment.
The mutex wasn't used anymore so it could be cleaned up.
|
This looks legit to me, thanks @dbussink. I'm going to cut a new release at 0.3.9 for this fix, and then begin work to clean things up after being away from the project for some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a wrapper class to put the logic for logging to an IO like object. This is to prevent having to put all the logic in the log.rb class itself based if it's a syslog instance or not.
It updates the tests to account for this and also removes the now unused mutex code.
Fixes the broken syslog logging currently on master, which fails with the following error:
Opted for this approach over implementing
printin the syslog class, since that would mean having to chop off the added newline there since syslog already handles the newline logic. By introducing the new class, this can be moved there to where the newline logic is needed.