Introduce abstraction for stream logging

lib/scrolls/iolog.rb

@@ -0,0 +1,12 @@
+module Scrolls
+  class IOLog
+    def initialize(stream)
+      stream.sync = true
+      @stream = stream
+    end
+
+    def log(data)
+      @stream.write("#{data}\n")
+    end
+  end
+end

lib/scrolls/log.rb

@@ -1,5 +1,6 @@
 require "scrolls/parser"
 require "scrolls/utils"
+require "scrolls/iolog"
 require "scrolls/syslog"
 
 module Scrolls
@@ -231,21 +232,14 @@ def calc_time(start, finish)
       ((finish - start).to_f * @t)
     end
 
-    def mtx
-      @mtx ||= Mutex.new
-    end
-
-    def sync_stream(out=nil)
-      out = STDOUT if out.nil?
-      s = out
-      s.sync = true
-      s
+    def sync_stream(out = STDOUT)
+      IOLog.new(out)
     end
 
     def write(data)
       if log_level_ok?(data[:level])
         msg = unparse(data)
-        stream.print(msg + "\n")
+        stream.log(msg)
       end
     end
 

lib/scrolls/syslog.rb

@@ -35,7 +35,7 @@ def initialize(ident = 'scrolls', facility = Syslog::LOG_USER)
       end
     end
 
-    def puts(data)
+    def log(data)
       @syslog.log(Syslog::LOG_INFO, "%s", data)
     end
 

test/test_scrolls.rb

@@ -14,7 +14,7 @@ def teardown
   end
 
   def test_construct
-    assert_equal StringIO, Scrolls.stream.class
+    assert_equal Scrolls::IOLog, Scrolls.stream.class
   end
 
   def test_default_global_context
@@ -130,7 +130,7 @@ def test_log_exception
 
     oneline_backtrace = @out.string.gsub("\n", 'XX')
 
-    assert_match /test=exception at=exception.*test_log_exception.*XX.*minitest/,
+    assert_match /test=exception at=exception.*test_log_exception.*XX/,
       oneline_backtrace
   end
 
@@ -165,6 +165,12 @@ def test_setting_syslog_facility_after_instantiation
     assert_match /facility=184/, Scrolls.stream.inspect
   end
 
+  def test_logging_message_with_syslog
+    Scrolls.stream = 'syslog'
+    Scrolls.facility = 'local7'
+    Scrolls.log "scrolls test"
+  end
+
   def test_add_timestamp
     Scrolls.add_timestamp = true
     Scrolls.log(:test => "foo")