feat: fix-visibility release artifacts #67
Conversation
f0rmiga
commented
Nov 17, 2021
•
f0rmiga
commented
- Refactors the release process to make it easier to include more artifacts.
- Adds the fix-visibility plugin to the list of released artifacts.
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
force-pushed
the
plugin-release-artifacts
branch
from
c93c8f2
to
62a45be
Compare
| @@ -16,18 +16,18 @@ jobs: | |||
| run: git status --porcelain | |||
| - name: bazel test //... | |||
| env: | |||
| # Bazelisk will download bazel to here | |||
| # Bazelisk will download bazel to here. | |||
There was a problem hiding this comment.
nit: we don't actually have to download bazelisk!
bazel-contrib/rules_bazel_integration_test#1 (comment)
There was a problem hiding this comment.
Will defer this to another PR.
| XDG_CACHE_HOME: ~/.cache/bazel-repo | ||
| run: | ||
| run: | | ||
| # Test the repository. | ||
| bazel --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test | ||
| --config=release //... |
There was a problem hiding this comment.
nit: maybe we don't want to test with --config=release since that causes some cache misses due to stamping non-determinism?
There was a problem hiding this comment.
I could argue that we don't need a test at all since we will only tag commits on main that were already tested.
| # shellcheck disable=SC2016 | ||
| echo 'mkdir -p "${dst}"' | ||
|
|
||
| for artifact in "$@"; do |
There was a problem hiding this comment.
huh, don't need $BUILD_WORKSPACE_DIRECTORY to hop back to source tree? I guess this binary has no runfiles so a different working dir
There was a problem hiding this comment.
No, the files are passed from $(locations ...) MAKEVARS from Bazel.
|
|
||
| load("@io_bazel_rules_go//go:def.bzl", "go_binary") | ||
|
|
||
| PLATFORMS = [ |
