Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial files #1

Merged
merged 22 commits into from
Nov 12, 2021
Merged

Initial files #1

merged 22 commits into from
Nov 12, 2021

Conversation

cgrindel
Copy link
Member

  • Added bazel_integration_test, bazel_integration_tests, and integration_test_utils.
  • Added simple example.
  • Defined integration tests that execute against the simple example workspace.
  • Generating doc.

@cgrindel cgrindel self-assigned this Nov 12, 2021
@cgrindel cgrindel merged commit 0a11e1e into main Nov 12, 2021
@cgrindel cgrindel deleted the initial_files branch November 12, 2021 19:37
import %workspace%/shared.bazelrc

# Import CI settings.
import %workspace%/ci.bazelrc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs, CI settings are exclusive from what users use

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is loaded for everyone. However, the settings in the file are all suffixed with :ci. In other words, they only take effect when the ci config is specified. This happens here. I use this pattern so that everyone can easily see what configuration values are used for CI vs development.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

- name: Write local.bazelrc File
shell: bash
run: |
cat >local.bazelrc <<EOF

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this where ci.bazelrc would be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. The common --config=ci tells Bazel to use the ci config values.

- name: Output the Bazel Info
shell: bash
run: |
bazelisk info

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble tracking down how you got bazelisk into here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am relying on bazelisk being installed in the runners.

MacOS Software
Ubuntu Software

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow! Today I Learned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants