process: sync commits from Aspect-internal silo #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and automated fixes (#5524) Don't duplicate header for results and fixes --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Aspect CLI lint command now prints a single header per target for both lint results and automated fixes ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: `aspect lint //...` on silo GitOrigin-RevId: 934f0a10fbb4253c8a52b24d129835dfaad9c96e
This flag was reversed and that resulted in starting the bazel server when we queried for the flags. It should be `--batch`: https://bazel.build/reference/command-line-reference#flag--batch --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Aspect CLI now runs `help flags-as-proto` with `--batch` set ### Test plan - Covered by existing test cases CI GitOrigin-RevId: 660a80bbbbd1c73e5283a42717176441081e72b4
### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 493305060982a8ea7a222f79bcea6fbf13aa8f36
It seems that gazelle of golang and proto was unintentionally turned off 2 months ago on March 21 by aspect-build/silo#4874 💩 --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: `bazel run //:gazelle.check` && `bazel run //:gazelle` GitOrigin-RevId: a628f22c6f7841416448b2dbcbfceeedce472a72
Adds async lint handler capabilities to the lint command --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases CI GitOrigin-RevId: 43dc3ae5e078f29598437c02ad9784230db0b0eb
|
alexeagle
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/bd6f22ddd271ea074592153be997fd1629a3743d..934f0a10fbb4253c8a52b24d129835dfaad9c96e