Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: sync commits from Aspect-internal silo #704

Merged
merged 6 commits into from
May 24, 2024

Commits on May 24, 2024

  1. refactor: only print a single header per target for both lint results…

    … and automated fixes (#5524)
    
    Don't duplicate header for results and fixes
    
    ---
    
    ### Changes are visible to end-users: yes
    
    - Searched for relevant documentation and updated as needed: yes
    - Breaking change (forces users to change their own code or config): no
    - Suggested release notes appear below: yes
    
    Aspect CLI lint command now prints a single header per target for both
    lint results and automated fixes
    
    ### Test plan
    
    - Covered by existing test cases
    - Manual testing; please provide instructions so we can reproduce:
    
    `aspect lint //...` on silo
    
    GitOrigin-RevId: 934f0a10fbb4253c8a52b24d129835dfaad9c96e
    gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f62edfe View commit details
    Browse the repository at this point in the history
  2. fix: flags-as-proto should set --batch (#5526)

    This flag was reversed and that resulted in starting the bazel server
    when we queried for the flags. It should be `--batch`:
    https://bazel.build/reference/command-line-reference#flag--batch
    
    ---
    
    ### Changes are visible to end-users: yes
    
    - Searched for relevant documentation and updated as needed: yes
    - Breaking change (forces users to change their own code or config): no
    - Suggested release notes appear below: yes
    
    Aspect CLI now runs `help flags-as-proto` with `--batch` set
    
    ### Test plan
    
    - Covered by existing test cases
    
    CI
    
    GitOrigin-RevId: 660a80bbbbd1c73e5283a42717176441081e72b4
    gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0bcc341 View commit details
    Browse the repository at this point in the history
  3. perf(gazelle): do not recurse into ignored directories (#5520)

    ### Changes are visible to end-users: no
    
    ### Test plan
    
    - Covered by existing test cases
    
    GitOrigin-RevId: 493305060982a8ea7a222f79bcea6fbf13aa8f36
    jbedard authored and gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e29023a View commit details
    Browse the repository at this point in the history
  4. build: re-enable gazelle for golang and proto (#5527)

    It seems that gazelle of golang and proto was unintentionally turned off
    2 months ago on March 21 by
    aspect-build/silo#4874 💩
    
    ---
    
    ### Changes are visible to end-users: no
    
    ### Test plan
    
    - Covered by existing test cases
    - Manual testing; please provide instructions so we can reproduce:
    
    `bazel run //:gazelle.check` && `bazel run //:gazelle`
    
    GitOrigin-RevId: a628f22c6f7841416448b2dbcbfceeedce472a72
    gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0dc8221 View commit details
    Browse the repository at this point in the history
  5. feat: add support for lint handler hooks (#5482)

    Adds async lint handler capabilities to the lint command
    
    ---
    
    ### Changes are visible to end-users: no
    
    ### Test plan
    
    - Covered by existing test cases
    
    CI
    
    GitOrigin-RevId: 43dc3ae5e078f29598437c02ad9784230db0b0eb
    gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c16def0 View commit details
    Browse the repository at this point in the history
  6. Update docs

    gregmagolan committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4308f2e View commit details
    Browse the repository at this point in the history