process: sync commits from Aspect-internal silo #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Typescript 🛻 --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 4e834c729ed4f6941c2ed2c60a58595d45cbb22e
…stead of one call per result (#5599) Refactor for the lint task --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases CI GitOrigin-RevId: cef7d390843a2cb8214c7ed2894f5eee83fa9ccb
Add the starzelle gazelle plugin by default pro cli. Starzelle plugins can be enabled via the `STARZELLE_PLUGINS` env var pointing to a directory of `*.lang.star` plugins. --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: a1e3c348874955e4e122ab873cd1a9334764f07a
### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 1301b058291548378130a7cbf800759f7acaac4f
### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: 32a3f0d11ea66f30e537534cc2e096fd6eba1614
We nil check `exitCodeFile` and `patchFile` but missed `reportFile` which can be nil --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: Run and check the output of the lint task GitOrigin-RevId: dbb8adf3127ad38f8eff560306213349a21ff98d
For local development and for silo CI it is desirable that the unstamped build of the Aspect CLI ignores the version of the CLI in the `.bazeliskrc` file in silo and does not re-enter by default. To override this behaviour you can set `--aspect:lock_version=false` on an unstamped cli. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Built stamped and unstamped versions of CLI pro locally and verified that the unstamped has the version always locked (no re-entrance into version specified in `.bazeliskrc`) GitOrigin-RevId: 5831b4485593e9370f294c217f382726e85e4e38
The cli configure code copied from gazelle hasn't been properly kept up to date the last few gazelle upgrades. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 6676d12da96a1d1010d7d1f92ebcb11fb1db7d22
All the changes in `cli/core/pkg/aspect/configure/*.go` are from syncing with the latest `bazel_gazelle` v0.37.0. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 842fa6010fd4ce675b26c45ce145d5a5ea94b85f
I had a case where `runFixUpdate` return `nil, err` and this crashed due to `stats` being `nil`. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 48c19c4fd248a2effac2f8fa188ec2f417f55065
### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 5bd7069fe8dcd397279083993c19206a2beb3415
…ndles (#5659) The core bazelbuild-gazel already respects .bazelignore --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: e13ae5fc294fb941ab752ad60486a594e525d012
Gazelle recently added utils for cpu + memory profiling to their CLI. This adds support for those using env vars, the CLI params and public API have not changed, this is not documented etc. --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: 9583236ba685f779baf678eaa5730c02105302bc
…ISK_BASE_URL= on the environment (#5675) From Airtable bug report: https://aspect-build.slack.com/archives/C05S94VJWNM/p1717780481562359?thread_ts=1717777056.588929&cid=C05S94VJWNM Airtable wants to be able to run, ``` BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel test //... ``` so they can test against nightly versions of Bazel on canary CI but there is a bug in Bazelisk where an empty env var such as `BAZELISK_BASE_URL=` does not override/clear the `BAZELISK_BASE_URL` value in `.bazeliskrc`. This fixes that bug. I looked upstream in Bazelisk and the way they load the configs and envs has drifted making it tricker to make this fix. Will not do that at this point. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Aspect CLI now allows for clearing the `.bazeliskrc` values such as `BAZELISK_BASE_URL` with the empty env var `BAZELISK_BASE_URL=`. Previously the empty value from the env was ignored and treated the same as the `BAZELISK_BASE_URL` key not being present on the env and the `.bazeliskrc` value would still be used. ### Test plan <!-- Delete any which do not apply --> - Manual testing; please provide instructions so we can reproduce: Ran ``` BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel-bin/cli/pro/pro_/pro version ``` locally: ``` BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel-bin/cli/pro/pro_/pro version 2024/06/07 10:26:27 Using unreleased version at commit 25cf03c04a743ad6698d5e722f3e9d5c5a019c47 Aspect CLI Pro version: unknown [not built with --stamp] 2024/06/07 10:26:27 Using unreleased version at commit 25cf03c04a743ad6698d5e722f3e9d5c5a019c47 Starting local Bazel server and connecting to it... Build target: @@//src/main/java/com/google/devtools/build/lib/bazel:BazelServer Build time: Thu Jan 01 00:00:00 1970 (0) Build timestamp: Thu Jan 01 00:00:00 1970 (0) Build timestamp as int: 0 ``` GitOrigin-RevId: e27563aedb24f14a85ed2072f23c0f995877997d
To prevent allocating arrays just to iterate over them. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 2cbaf6255c5b1496f17ee3546e4812f19f257d1c
A simple alias for now. Docs and things like `# gazelle:` references in error messages and docs are not updated. Various tests have been changed to use the alias. `bazel-gazelle` in both the go.mod and `http_archive` are patched so this applies to both the `gazelle_binary` and `bazel configure`. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: f974173963d5c01fff686a9093ad90d36c5ca581
GitOrigin-RevId: 514ba20025bfd449231a2884638cdf394622b77e
This way gazelle doesn't have to loop over both names every time. If configured in the root BUILD it will often prevent 1 `fs.Stat` per directory. See `build_file_name` at https://github.com/bazelbuild/bazel-gazelle?tab=readme-ov-file#fix-and-update --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: c7eee0006420233aa9b69bb66681491b7ecfaff1
GitOrigin-RevId: 28581789342b4d9fefde5edac11c3c0da786c4c3
|
alexeagle
force-pushed
the
D5E6C3085CF669C3102897C2089A5B5C
branch
from
3ebe8ce
to
12e1a9f
Compare
jbedard
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/580f85e4ccbdb3124c75d39c220c0e686667acb2..4e834c729ed4f6941c2ed2c60a58595d45cbb22e