Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: sync commits from Aspect-internal silo #712

Merged
merged 21 commits into from
Jun 10, 2024
Merged

process: sync commits from Aspect-internal silo #712

merged 21 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. chore: bump Typescript versions (#5598) 

    Upgrade Typescript 🛻

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 4e834c729ed4f6941c2ed2c60a58595d45cbb22e
    @mattem @alexeagle
    mattem authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5eed124 View commit details
    Browse the repository at this point in the history

  2. refactor: switch lint handler to be a single call with all results in… 

    …stead of one call per result (#5599)

Refactor for the lint task

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

CI

GitOrigin-RevId: cef7d390843a2cb8214c7ed2894f5eee83fa9ccb
    @gregmagolan @alexeagle
    gregmagolan authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3b157d2 View commit details
    Browse the repository at this point in the history

  3. feat(cli): add pro-configure command with starzelle plugins (#5612) 

    Add the starzelle gazelle plugin by default pro cli. Starzelle plugins can be enabled via the `STARZELLE_PLUGINS` env var pointing to a directory of `*.lang.star` plugins.

---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:

GitOrigin-RevId: a1e3c348874955e4e122ab873cd1a9334764f07a
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    880c275 View commit details
    Browse the repository at this point in the history

  4. refactor: starzelle native library setup (#5624) 

    ### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 1301b058291548378130a7cbf800759f7acaac4f
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    446046a View commit details
    Browse the repository at this point in the history

  5. docs(gazelle): correct js_tsconfig directive docs (#5627) 

    ### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:

GitOrigin-RevId: 32a3f0d11ea66f30e537534cc2e096fd6eba1614
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    40e246c View commit details
    Browse the repository at this point in the history

  6. fix(CLI): Ensure reportFile is not nil when processing (#5636) 

    We nil check `exitCodeFile` and `patchFile` but missed `reportFile`
which can be nil

---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Run and check the output of the lint task

GitOrigin-RevId: dbb8adf3127ad38f8eff560306213349a21ff98d
    @JesseTatasciore @alexeagle
    JesseTatasciore authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    46e867e View commit details
    Browse the repository at this point in the history

  7. fix: lock version of Aspect CLI by default when unstamped (#5648) 

    For local development and for silo CI it is desirable that the unstamped
build of the Aspect CLI ignores the version of the CLI in the
`.bazeliskrc` file in silo and does not re-enter by default. To override
this behaviour you can set `--aspect:lock_version=false` on an unstamped
cli.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- Manual testing; please provide instructions so we can reproduce:

Built stamped and unstamped versions of CLI pro locally and verified
that the unstamped has the version always locked (no re-entrance into
version specified in `.bazeliskrc`)

GitOrigin-RevId: 5831b4485593e9370f294c217f382726e85e4e38
    @gregmagolan @alexeagle
    gregmagolan authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d3436a8 View commit details
    Browse the repository at this point in the history

  8. refactor: align sync cli configure code with gazelle (#5649) 

    The cli configure code copied from gazelle hasn't been properly kept up
to date the last few gazelle upgrades.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 6676d12da96a1d1010d7d1f92ebcb11fb1db7d22
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    32fb094 View commit details
    Browse the repository at this point in the history

  9. build: upgrade gazelle v0.37 (#5640) 

    All the changes in `cli/core/pkg/aspect/configure/*.go` are from syncing
with the latest `bazel_gazelle` v0.37.0.

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 842fa6010fd4ce675b26c45ce145d5a5ea94b85f
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e55e451 View commit details
    Browse the repository at this point in the history

  10. fix(gazelle): do not output stats on error (#5661) 

    I had a case where `runFixUpdate` return `nil, err` and this crashed due
to `stats` being `nil`.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 48c19c4fd248a2effac2f8fa188ec2f417f55065
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2f4b042 View commit details
    Browse the repository at this point in the history

  11. refactor(cli): update comments referencing gazelle src (#5660) 

    ### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 5bd7069fe8dcd397279083993c19206a2beb3415
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e4affa6 View commit details
    Browse the repository at this point in the history

  12. refactor(cli): remove processing of .bazelignore which gazelle now ha… 

    …ndles (#5659)

The core bazelbuild-gazel already respects .bazelignore

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: e13ae5fc294fb941ab752ad60486a594e525d012
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    45d27b5 View commit details
    Browse the repository at this point in the history

  13. refactor(cli): enable gazelle profiling via env vars (#5658) 

    Gazelle recently added utils for cpu + memory profiling to their CLI.
This adds support for those using env vars, the CLI params and public
API have not changed, this is not documented etc.

---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:

GitOrigin-RevId: 9583236ba685f779baf678eaa5730c02105302bc
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    71fdae3 View commit details
    Browse the repository at this point in the history

  14. fix: allow for clearing BAZELISK_BASE_URL in the Aspect CLI via BAZEL… 

    …ISK_BASE_URL= on the environment (#5675)

From Airtable bug report:
https://aspect-build.slack.com/archives/C05S94VJWNM/p1717780481562359?thread_ts=1717777056.588929&cid=C05S94VJWNM

Airtable wants to be able to run,

```
BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel test //...
```

so they can test against nightly versions of Bazel on canary CI but
there is a bug in Bazelisk where an empty env var such as
`BAZELISK_BASE_URL=` does not override/clear the `BAZELISK_BASE_URL`
value in `.bazeliskrc`. This fixes that bug.

I looked upstream in Bazelisk and the way they load the configs and envs
has drifted making it tricker to make this fix. Will not do that at this
point.

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

Aspect CLI now allows for clearing the `.bazeliskrc` values such as
`BAZELISK_BASE_URL` with the empty env var `BAZELISK_BASE_URL=`.
Previously the empty value from the env was ignored and treated the same
as the `BAZELISK_BASE_URL` key not being present on the env and the
`.bazeliskrc` value would still be used.

### Test plan

<!-- Delete any which do not apply -->

- Manual testing; please provide instructions so we can reproduce:

Ran
```
BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel-bin/cli/pro/pro_/pro version
```

locally:

```
BAZELISK_BASE_URL= USE_BAZEL_VERSION=25cf03c04a743ad6698d5e722f3e9d5c5a019c47 bazel-bin/cli/pro/pro_/pro version
2024/06/07 10:26:27 Using unreleased version at commit 25cf03c04a743ad6698d5e722f3e9d5c5a019c47
Aspect CLI Pro version: unknown [not built with --stamp]
2024/06/07 10:26:27 Using unreleased version at commit 25cf03c04a743ad6698d5e722f3e9d5c5a019c47
Starting local Bazel server and connecting to it...
Build target: @@//src/main/java/com/google/devtools/build/lib/bazel:BazelServer
Build time: Thu Jan 01 00:00:00 1970 (0)
Build timestamp: Thu Jan 01 00:00:00 1970 (0)
Build timestamp as int: 0
```
GitOrigin-RevId: e27563aedb24f14a85ed2072f23c0f995877997d
    @gregmagolan @alexeagle
    gregmagolan authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ce6883f View commit details
    Browse the repository at this point in the history

  15. refactor(starzelle): traverse starlark Dict using iterators (#5670) 

    To prevent allocating arrays just to iterate over them.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 2cbaf6255c5b1496f17ee3546e4812f19f257d1c
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    647242d View commit details
    Browse the repository at this point in the history

  16. feat(cli): support #aspect: gazelle directives (#5678) 

    A simple alias for now. Docs and things like `# gazelle:` references in
error messages and docs are not updated. Various tests have been changed
to use the alias.

`bazel-gazelle` in both the go.mod and `http_archive` are patched so
this applies to both the `gazelle_binary` and `bazel configure`.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

GitOrigin-RevId: f974173963d5c01fff686a9093ad90d36c5ca581
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0fededf View commit details
    Browse the repository at this point in the history

  17. chore: upgrade go-git to v5 (#5685) 

    GitOrigin-RevId: 514ba20025bfd449231a2884638cdf394622b77e
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5230b95 View commit details
    Browse the repository at this point in the history

  18. feat(gazelle): respect #gazelle:build_file_name (#5684) 

    This way gazelle doesn't have to loop over both names every time. If
configured in the root BUILD it will often prevent 1 `fs.Stat` per
directory.

See `build_file_name` at
https://github.com/bazelbuild/bazel-gazelle?tab=readme-ov-file#fix-and-update

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: c7eee0006420233aa9b69bb66681491b7ecfaff1
    @jbedard @alexeagle
    jbedard authored and alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    499f66a View commit details
    Browse the repository at this point in the history

  19. feat(cli/configure): add BUILD generation for Python (#5698) 

    GitOrigin-RevId: 28581789342b4d9fefde5edac11c3c0da786c4c3
    @alexeagle
    alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8dd2bef View commit details
    Browse the repository at this point in the history

  20. chore: go mod tidy

    @alexeagle
    alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    12e1a9f View commit details
    Browse the repository at this point in the history

  21. chore: patch gazelle to allow 'aspect' directives

    @alexeagle
    alexeagle committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    948fd68 View commit details
    Browse the repository at this point in the history