feat(sdk): create sdk version v1alpha2 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
4 times, most recently
from
b01c72e
to
1776be2
Compare
f0rmiga
suggested changes
Jan 6, 2022
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
2 times, most recently
from
b16a88c
to
36b22da
Compare
f0rmiga
reviewed
Jan 6, 2022
|
|
||
| // Handshake is the shared handshake config for the v1alpha1 protocol. | ||
| var Handshake = goplugin.HandshakeConfig{ | ||
| ProtocolVersion: 1, |
There was a problem hiding this comment.
I think the number of changes we will make to the SDK, this will have to bump. Not in this PR, though.
f0rmiga
reviewed
Jan 6, 2022
f0rmiga
reviewed
Jan 6, 2022
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
from
36b22da
to
d21f76a
Compare
…t changes to certain files and folders
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
from
d21f76a
to
59047f0
Compare
f0rmiga
approved these changes
Jan 7, 2022
f0rmiga
changed the title
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
4 times, most recently
from
b352044
to
bc4ca4d
Compare
JesseTatasciore
force-pushed
the
jtatasciore/create-sdk-v1alpha2
branch
from
bc4ca4d
to
b74ed2d
Compare
f0rmiga
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.