Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: eslint checking output files when there are zero sources #368

Closed
alexeagle opened this issue Aug 21, 2024 · 0 comments · Fixed by #370
Closed

[Bug]: eslint checking output files when there are zero sources #368

alexeagle opened this issue Aug 21, 2024 · 0 comments · Fixed by #370
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

What happened?

In #331 I changed eslint and dropped the logic that checked for zero files.
https://github.com/aspect-build/rules_lint/pull/331/files#diff-6c41bd6f23bdcf48b0a646963feda9493b9cff7e4bc6c6c8dac48aecbf1136b7L190

When you use ts_project(transpiler) you get a js_library target with no sources, just re-exports. When you lint this target we now run eslint with no specific files, so it lints everything it can find.

Version

v1.0.0-rc6 through v1.0.0-rc8

How to reproduce

Adding a test for this in the fix

Any other information?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant