feat: produce new human-readable output group #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure linters to be colored and produce prettier output for this new output. Change lint.sh to present this output rather than the 'report' output which is machine-readable Fixes #324
alexeagle
changed the title
It makes our tests more complex
gregmagolan
reviewed
Jul 16, 2024
…tput for exit code
alexeagle
changed the title
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
gregmagolan
reviewed
Jul 17, 2024
Allows simplification of short-circuit logic for linting zero inputs
gregmagolan
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now two output_groups that users or wrapper tools can request:
rules_lint_humanandrules_lint_machine.Every linter is updated to produce outputs for both groups. The "human" output group uses nicer formats.
Change
lint.shto present this output rather than the 'report' output which is machine-readable.We can make a corresponding change in Aspect CLI.
The
rules_lint_reportoutput group is retained to make this non-breaking.Fixes #324