Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use write_source_files where possible #178

Merged
merged 1 commit into from
Mar 2, 2023
Merged

test: use write_source_files where possible #178

merged 1 commit into from
Mar 2, 2023

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Mar 2, 2023

These are bugging me now, and I think show more issues that #176 should fix.

@jbedard jbedard requested review from alexeagle and thesayyn March 2, 2023 23:28
@jbedard jbedard merged commit bb8898c into main Mar 2, 2023
@jbedard jbedard deleted the tests-write_source branch March 2, 2023 23:31
alexeagle
alexeagle reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should always check in golden files. I don't think we ever meant to assert on the contents of these files, the golden file tests are brittle and change more frequently.

@jbedard
Copy link
Member Author

jbedard commented Mar 3, 2023

No not always, but I had issues that I thought these tests should be catching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle left review comments

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbedard @alexeagle @thesayyn