docs: alias LATEST_VERSION as TS_LATEST_VERSION in example snippets

Fix aspect-build/rules_js#817
aspect-build · Apr 19, 2023 · 7f3f62d · 7f3f62d
1 parent ccdc52e
commit 7f3f62d
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 12 deletions.
diff --git a/e2e/external_dep/WORKSPACE b/e2e/external_dep/WORKSPACE
@@ -5,8 +5,9 @@ local_repository(
     path = "../..",
 )
 
-load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
-rules_ts_dependencies(ts_version = LATEST_VERSION)
+load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies", TS_LATEST_VERSION = "LATEST_VERSION")
+
+rules_ts_dependencies(ts_version = TS_LATEST_VERSION)
 
 # Fetch and register node, if you haven't already
 load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

diff --git a/e2e/external_dep/app/WORKSPACE b/e2e/external_dep/app/WORKSPACE
@@ -2,13 +2,15 @@ local_repository(
     name = "aspect_rules_ts",
     path = "../../..",
 )
+
 local_repository(
     name = "lib_wksp",
     path = "..",
 )
 
-load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
-rules_ts_dependencies(ts_version = LATEST_VERSION)
+load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies", TS_LATEST_VERSION = "LATEST_VERSION")
+
+rules_ts_dependencies(ts_version = TS_LATEST_VERSION)
 
 # Fetch and register node, if you haven't already
 load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

diff --git a/e2e/test/common.bats b/e2e/test/common.bats
@@ -19,9 +19,9 @@ local_repository(
     path = "$rules_ts_path",
 )
 
-load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
+load("@aspect_rules_ts//ts:repositories.bzl", TS_LATEST_VERSION = "LATEST_VERSION", "rules_ts_dependencies")
 
-rules_ts_dependencies(ts_version = LATEST_VERSION)
+rules_ts_dependencies(ts_version = TS_LATEST_VERSION)
 
 # Fetch and register node, if you haven't already
 load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

diff --git a/e2e/worker/WORKSPACE b/e2e/worker/WORKSPACE
@@ -5,8 +5,9 @@ local_repository(
     path = "../..",
 )
 
-load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
-rules_ts_dependencies(ts_version = LATEST_VERSION)
+load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies", TS_LATEST_VERSION = "LATEST_VERSION")
+
+rules_ts_dependencies(ts_version = TS_LATEST_VERSION)
 
 # Fetch and register node, if you haven't already
 load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

diff --git a/e2e/workspace/WORKSPACE b/e2e/workspace/WORKSPACE
@@ -21,8 +21,8 @@ rules_ts_dependencies(
     ts_version_from = "//:package.json",
 
     # Alternatively, you could pick a specific version, or use
-    # load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION")
-    # ts_version = LATEST_VERSION
+    # load("@aspect_rules_ts//ts:repositories.bzl", TS_LATEST_VERSION = "LATEST_VERSION")
+    # ts_version = TS_LATEST_VERSION
 )
 
 # Fetch and register node, if you haven't already

diff --git a/ts/extensions.bzl b/ts/extensions.bzl
@@ -3,7 +3,7 @@ See https://bazel.build/docs/bzlmod#extension-definition
 """
 
 load("//ts/private:npm_repositories.bzl", "npm_dependencies")
-load("//ts:repositories.bzl", "LATEST_VERSION")
+load("//ts:repositories.bzl", TS_LATEST_VERSION = "LATEST_VERSION")
 
 def _extension_impl(module_ctx):
     for mod in module_ctx.modules:
@@ -13,6 +13,6 @@ def _extension_impl(module_ctx):
 ext = module_extension(
     implementation = _extension_impl,
     tag_classes = {
-        "deps": tag_class(attrs = {"ts_version": attr.string(default = LATEST_VERSION), "ts_integrity": attr.string()}),
+        "deps": tag_class(attrs = {"ts_version": attr.string(default = TS_LATEST_VERSION), "ts_integrity": attr.string()}),
     },
 )