Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add renamed symbols to the release snippets #817

Closed
1 task
paullewis opened this issue Jan 24, 2023 · 1 comment · Fixed by aspect-build/rules_ts#354
Closed
1 task

[FR]: Add renamed symbols to the release snippets #817

paullewis opened this issue Jan 24, 2023 · 1 comment · Fixed by aspect-build/rules_ts#354
Labels
enhancement New feature or request

Comments

@paullewis
Copy link

What is the current behavior?

Today when you import any of the Aspect rules they usually have a LATEST_VERSION value:

load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies", "LATEST_VERSION")

Describe the feature

Super minor, but when you have multiple rules on the go you end up renaming LATEST_VERSION to something like TS_LATEST_VERSION in the WORKSPACE to avoid clashes with other LATEST_VERSIONs, i.e.,

load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies", TS_LATEST_VERSION = "LATEST_VERSION")

I wondered whether it would be worth either updating the snippet that folks copy-paste, or renaming LATEST_VERSION to be rules-specific.

Fund our work

@paullewis paullewis added the enhancement New feature or request label Jan 24, 2023
@gregmagolan
Copy link
Member

Thanks for the suggestion @paullewis. I think its a good idea to reduce friction.

@gregmagolan gregmagolan added this to the Performance & Docs milestone Mar 17, 2023
jbedard added a commit to aspect-build/rules_ts that referenced this issue Apr 19, 2023
This previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
jbedard added a commit to aspect-build/rules_ts that referenced this issue Apr 20, 2023
This previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
jbedard added a commit to aspect-build/rules_ts that referenced this issue Apr 20, 2023
This previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
jbedard added a commit to aspect-build/rules_esbuild that referenced this issue Apr 21, 2023
jbedard added a commit to aspect-build/rules_swc that referenced this issue Apr 21, 2023
jbedard added a commit to aspect-build/rules_swc that referenced this issue Apr 21, 2023
jbedard added a commit to aspect-build/rules_terser that referenced this issue Apr 21, 2023
jbedard added a commit to aspect-build/rules_deno that referenced this issue Apr 21, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: LATEST_VERSION has been renamed to LATEST_DENO_VERSION
jbedard added a commit to aspect-build/rules_cypress that referenced this issue Apr 21, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: LATEST_VERSION has been renamed to LATEST_CYPRESS_VERSION
jbedard added a commit to aspect-build/rules_esbuild that referenced this issue Apr 21, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: rename LATEST_VERSION to LATEST_ESBUILD_VERSION
jbedard added a commit to aspect-build/rules_ts that referenced this issue May 1, 2023
This previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
jbedard added a commit to aspect-build/rules_ts that referenced this issue May 1, 2023
The previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
jbedard added a commit to aspect-build/rules_swc that referenced this issue May 1, 2023
jbedard added a commit to aspect-build/rules_swc that referenced this issue May 1, 2023
jbedard added a commit to aspect-build/rules_swc that referenced this issue May 1, 2023
gregmagolan pushed a commit to aspect-build/rules_cypress that referenced this issue May 2, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: LATEST_VERSION has been renamed to LATEST_CYPRESS_VERSION
gregmagolan pushed a commit to aspect-build/rules_deno that referenced this issue May 2, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: LATEST_VERSION has been renamed to LATEST_DENO_VERSION
gregmagolan pushed a commit to aspect-build/rules_esbuild that referenced this issue May 2, 2023
See aspect-build/rules_js#817

BREAKING CHANGE: rename LATEST_VERSION to LATEST_ESBUILD_VERSION
alexeagle pushed a commit to aspect-build/rules_ts that referenced this issue Aug 7, 2023
The previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants