You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Kestrel tests have hundrends of this scary-looking warning from xunit:
[12:02:22] : [Step 4/7] [xUnit.net 00:00:00.3409135] Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Tests: Non-serializable data
('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Tests.LibuvTransportTests.TransportCanBindUnbindAndStop';
falling back to single test case.
They started when xUnit diagnostics messages were enabled (#2505). We should investigate what's causing these warnings, what is their implication (does it mean less tests are run than expected), and how to fix them.
The text was updated successfully, but these errors were encountered:
- xUnit diagnostic messages were enabled in #2505 to help identify hung tests
- However, this also enables log messages for non-serializable theory data (#2509), which adds noise to logs
- It doesn't seem possible to disable the "non-serializable data" messages but keep the "long-running test" messages
- Converting all tests to serializable theory data is expensive and complicates test code
- The best solution for now is to revert xUnit diagnostic messages to disabled, and re-enable when needed to identify hung tests
Kestrel tests have hundrends of this scary-looking warning from xunit:
http://aspnetci/viewLog.html?buildId=451476&tab=buildLog&buildTypeId=Lite_KestrelHttpServer&logTab=tree&filter=all&_focus=847#_state=350
They started when xUnit diagnostics messages were enabled (#2505). We should investigate what's causing these warnings, what is their implication (does it mean less tests are run than expected), and how to fix them.
The text was updated successfully, but these errors were encountered: