This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Enable xUnit diagnostic messages #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeharder
commented
Apr 18, 2018
•
mikeharder
commented
- Required to log long-running tests
- Will help investigate Flaky Test: Hang in Libuv and Sockets FunctionalTests/netcoreapp2.1 #2503
BrennanConroy
approved these changes
Apr 18, 2018
|
Verified the new setting is working (this particular test is long-running by design): |
|
CC: @ryanbrandenburg |
mikeharder
added a commit
that referenced
this pull request
Apr 24, 2018
This reverts commit f3afbeb.
mikeharder
added a commit
that referenced
this pull request
Apr 25, 2018
- xUnit diagnostic messages were enabled in #2505 to help identify hung tests - However, this also enables log messages for non-serializable theory data (#2509), which adds noise to logs - It doesn't seem possible to disable the "non-serializable data" messages but keep the "long-running test" messages - Converting all tests to serializable theory data is expensive and complicates test code - The best solution for now is to revert xUnit diagnostic messages to disabled, and re-enable when needed to identify hung tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.