Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR intends to just upgrade the
ruff
version.As you can see I modified the version in
pyproject.toml
underdependencies
.I ran both
pip-tools
commands to generate therequirements.txt
and therequirements-dev.txt
files:pip-compile --output-file=requirements.txt --resolver=backtracking pyproject.toml
pip-compile --extra=dev --output-file=requirements-dev.txt --resolver=backtracking pyproject.toml
I used
python@3.8
since that is the oldestpython
version I currently have in my system. It should not be a problem AFAIK.My motivation for this change:
I am a Sublime Text user (I know, I know...) and I have recently reset my whole editor from scratch since after all these years it had too many plugins installed and my config files were a mess.
I completely made the switch to
ruff
(awesome tool btw, thanks!) after finding about it. (that was the main motivation to reset my whole editor tbh!)To properly use
ruff
I installed the related sublimelsp/LSP-ruff plugin which depends directly on this project (ruff-lsp
).After a lot of head scratching I figured out why my config wasn't working, it was because some of the features I absolutely need (isort related) are only available on the latest version of
ruff
.I looked into the code and I saw its direct dependency with
ruff-lsp
The plugin installs
ruff-lsp@0.0.24
andruff@0.0.253
so I patched it with a soft link for the time being to my local install withruff@0.0.263
, although this is far from a solution:My thinking process is that if
ruff-lsp
releases a0.0.25
version withruff
at the latest version, then the plugin would need to pull the0.0.25
version and theruff
version would be the one with the features I am looking for.Please let me know if what I am saying is valid or if I got it wrong!