Only one server restart at a time #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully solves #142
MichaReiser
reviewed
May 16, 2023
src/extension.ts
Outdated
| @@ -33,7 +35,28 @@ export async function activate(context: vscode.ExtensionContext): Promise<void> | |||
| traceVerbose(`Configuration: ${JSON.stringify(serverInfo)}`); | |||
|
|
|||
| const runServer = async () => { | |||
| client = await restartServer(serverId, serverName, outputChannel, client); | |||
| if (clientPromise) { | |||
There was a problem hiding this comment.
clientPromise != null
Let's not depend on implicit conversion (it's safe here because it is a promise). We should add eslint or Rome
There was a problem hiding this comment.
Please add the appropriate tooling! I'm not up to date what the appropriate tooling in the js ecosystem is.
There was a problem hiding this comment.
i tried adding eslint and it didn't flag this, i think i got the wrong set of rules
There was a problem hiding this comment.
Oh sorry. I missed this comment. We can add eslint (or Rome :P) as a separate PR.
|
I confirmed that the code works but doesn't fix the problem. Not sure what to do with this |
MichaReiser
approved these changes
May 22, 2023
charliermarsh
added a commit
that referenced
this pull request
Jun 17, 2023
## Summary This PR overhauls the LSP client to pull in a bunch of improvements that've been made to the upstream template, primarily through these two PRs: - microsoft/vscode-python-tools-extension-template#100 - microsoft/vscode-python-tools-extension-template#99 Some of the issues that those PRs fixed, we've actually fixed already -- but that team knows the LSP and VS Code much, much better, and so I'm happy to pull in their changes. We've obviously diverged a bit from the original template, so pulling in these changes while preserving our own deviations is tricky... But, in particular, I had to do the following: - Change the code in `settings.ts` to match our settings schema, defaults, etc. - Change the code in `extension.ts` to register our custom actions. - Change the code in `extension.ts` to support enabling and disabling the extension (#222). - Change the code in `extension.ts` to debounce restarts (#194, #218).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully solves #127
I still have to find a better way to test this