Pull in updates to VS Code template extension #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/logging
branch
from
fb5de30
to
92f212f
Compare
charliermarsh
force-pushed
the
charlie/logging
branch
from
bb1b525
to
bf8dfce
Compare
charliermarsh
force-pushed
the
charlie/logging
branch
from
bf8dfce
to
c2ffd0c
Compare
charliermarsh
added a commit
to astral-sh/ruff-lsp
that referenced
this pull request
Jun 17, 2023
## Summary Similar to astral-sh/ruff-vscode#226, but for the server.
azurelotus0926
added a commit
to azurelotus0926/ruff-lsp
that referenced
this pull request
Jun 27, 2024
## Summary Similar to astral-sh/ruff-vscode#226, but for the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR overhauls the LSP client to pull in a bunch of improvements that've been made to the upstream template, primarily through these two PRs:
Some of the issues that those PRs fixed, we've actually fixed already -- but that team knows the LSP and VS Code much, much better, and so I'm happy to pull in their changes.
We've obviously diverged a bit from the original template, so pulling in these changes while preserving our own deviations is tricky... But, in particular, I had to do the following:
settings.tsto match our settings schema, defaults, etc.extension.tsto register our custom actions.extension.tsto support enabling and disabling the extension (Add a setting to enable or disable the extension #222).extension.tsto debounce restarts (Only one server restart at a time #194, Restore client inextension.ts#218).