Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more architectures #385

Closed
wants to merge 1 commit into from
Closed

support more architectures #385

wants to merge 1 commit into from

Conversation

diceroll123
Copy link

Summary

Support a few more architectures

Test Plan

I have not tested it. Ideally the PR will do a dry run.

@diceroll123
Copy link
Author

Guess not!

@konstin
Copy link
Member

konstin commented Jan 15, 2024

We have to manually approve CI runs each times for first-time contributors unfortunately. You can activate github actions in your fork and make a PR in your fork to test.

@diceroll123
Copy link
Author

Updated.

In my PR on my fork, I:

  • made it so release workflow runs on PR, for testing purposes
  • disabled macos builds because they cost money apparently
  • removed the build ID and publish steps because I didn't need them

But the only changes I've brought over to here are the build architectures. Attached is the list of successful actions!

image

aarch64-unknown-linux-musl I believe is what will allow us to use ruff within a devcontainer running on alpine linux, can't wait! 😄

@charliermarsh
Copy link
Member

I can do some testing and ultimately build for nightly, thanks :)

- os: ubuntu-20.04
target: armv7-unknown-linux-musleabihf
code-target: linux-armhf
arch: armv7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't quite right because these code-target values are the same as the ones above. We need to support alpine-x64 and alpine-arm64. See: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to play around with things (#387) to understand how this works. I think we need the extension itself to be built under Alpine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diceroll123 -- Okay, I think I got this working here -- notice how the build is done within an Alpine container, does that make sense?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! Awesome stuff. 😄 Learning a lot from ya.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and sorry that it didn't get merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants