-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support more architectures #385
Conversation
Guess not! |
We have to manually approve CI runs each times for first-time contributors unfortunately. You can activate github actions in your fork and make a PR in your fork to test. |
I can do some testing and ultimately build for nightly, thanks :) |
- os: ubuntu-20.04 | ||
target: armv7-unknown-linux-musleabihf | ||
code-target: linux-armhf | ||
arch: armv7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this isn't quite right because these code-target
values are the same as the ones above. We need to support alpine-x64
and alpine-arm64
. See: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to play around with things (#387) to understand how this works. I think we need the extension itself to be built under Alpine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diceroll123 -- Okay, I think I got this working here -- notice how the build is done within an Alpine container, does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely! Awesome stuff. 😄 Learning a lot from ya.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, and sorry that it didn't get merged!
Summary
Support a few more architectures
Test Plan
I have not tested it. Ideally the PR will do a dry run.