Include Alpine in target platforms #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/alpine
branch
2 times, most recently
from
8a619ab to
d4e8d36
Compare
charliermarsh
changed the title
MichaReiser
approved these changes
Jan 15, 2024
That's my attitude too lol |
charliermarsh
force-pushed
the
charlie/alpine
branch
from
d4e8d36 to
c28d184
Compare
charliermarsh
force-pushed
the
charlie/alpine
branch
from
c28d184 to
afbd9ef
Compare
|
Appears to have worked with a nightly build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that we publish VS Code extensions for the
alpine-x86andalpine-arm64target platforms.See https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions for details:
Test Plan
Performed a dry run, and verified that Ruff selected the correct musl wheel for x86:
And again for arm: