Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Compare expression inference - BytesLiteral #13687

Closed
Tracked by #13618
MichaReiser opened this issue Oct 9, 2024 · 0 comments · Fixed by #13746
Closed
Tracked by #13618

[red-knot] Compare expression inference - BytesLiteral #13687

MichaReiser opened this issue Oct 9, 2024 · 0 comments · Fixed by #13746
Assignees
@sharkdp
Labels
red-knot Multi-file analysis & type inference

Comments

@MichaReiser
Copy link
Member

MichaReiser commented Oct 9, 2024 •
edited
Loading

Same as #13634 but for bytes literal.

There might be a way to unify some of the implementation by making use of Rust's Eq ane PartialOrd traits.
@MichaReiser MichaReiser mentioned this issue Oct 9, 2024
Closed
13 tasks
@MichaReiser MichaReiser changed the title BytesLiteral Compare expression inference - BytesLiteral Oct 9, 2024
@MichaReiser MichaReiser self-assigned this Oct 9, 2024
@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Oct 9, 2024
@AlexWaygood AlexWaygood changed the title Compare expression inference - BytesLiteral [red-knot] Compare expression inference - BytesLiteral Oct 10, 2024
@sharkdp sharkdp assigned sharkdp and unassigned MichaReiser Oct 14, 2024
sharkdp added a commit that referenced this issue Oct 14, 2024
@sharkdp
[red-knot] feat: add BytesLiteral comparison
05f2a0f 
Implements inference for `BytesLiteral` comparisons along the lines of
#13634.

closes #13687
sharkdp added a commit that referenced this issue Oct 14, 2024
@sharkdp
[red-knot] feat: add BytesLiteral comparison
dc5882f 
Implements inference for `BytesLiteral` comparisons along the lines of
#13634.

closes #13687
sharkdp added a commit that referenced this issue Oct 14, 2024
@sharkdp
[red-knot] feat: add BytesLiteral comparison
66f3312 
Implements inference for `BytesLiteral` comparisons along the lines of
#13634.

closes #13687
@sharkdp sharkdp mentioned this issue Oct 14, 2024
Merged
sharkdp added a commit that referenced this issue Oct 14, 2024
@sharkdp @AlexWaygood
[red-knot] feat: Inference for BytesLiteral comparisons (#13746)
93097f1 
Implements inference for `BytesLiteral` comparisons along the lines of
#13634.

closes #13687

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharkdp sharkdp

Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[red-knot] feat: Inference for BytesLiteral comparisons astral-sh/ruff
2 participants
@MichaReiser @sharkdp