Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Compare expressions #13618

Closed
13 tasks done
Tracked by #12701
Slyces opened this issue Oct 3, 2024 · 0 comments
Closed
13 tasks done
Tracked by #12701

[red-knot] Compare expressions #13618

Slyces opened this issue Oct 3, 2024 · 0 comments
Labels
red-knot Multi-file analysis & type inference

Comments

@Slyces
Copy link
Contributor

Slyces commented Oct 3, 2024 •
edited by sharkdp
Loading

This is a roadmap of features and // TODO to mark compare expression as complete in #12701.
@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Oct 4, 2024
This was referenced Oct 4, 2024
Merged
Closed
carljm pushed a commit that referenced this issue Oct 5, 2024
@Slyces @AlexWaygood
[red-knot] feat: add StringLiteral and LiteralString comparison (#…
8108f83 
…13634)

## Summary

Implements string literal comparisons and fallbacks to `str` instance
for `LiteralString`.
Completes an item in #13618

## Test Plan

- Adds a dedicated test with non exhaustive cases

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@carljm carljm mentioned this issue Oct 7, 2024
Open
21 tasks
This was referenced Oct 9, 2024
Closed
Merged
carljm added a commit that referenced this issue Oct 16, 2024
@cake-monotone @carljm
[red-knot] Implement Type::Tuple Comparisons (#13712)
2ffc3fa 
## Summary

This PR implements comparisons for (tuple, tuple).

It will close #13688 and complete an item in #13618 once merged.

## Test Plan

Basic tests are included for (tuple, tuple) comparisons.

---------

Co-authored-by: Carl Meyer <carl@astral.sh>
This was referenced Oct 16, 2024
Closed
Closed
@cake-monotone cake-monotone mentioned this issue Oct 22, 2024
Closed
@sharkdp sharkdp closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sharkdp @Slyces @dhruvmanila