Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Compare expression inference - Tuple #13688

Closed
Tracked by #13618
cake-monotone opened this issue Oct 9, 2024 · 0 comments · Fixed by #13712
Closed
Tracked by #13618

[red-knot] Compare expression inference - Tuple #13688

cake-monotone opened this issue Oct 9, 2024 · 0 comments · Fixed by #13712
Assignees
@cake-monotone
Labels
red-knot Multi-file analysis & type inference

Comments

@cake-monotone
Copy link
Contributor

Related to #13618

I’m creating this issue to avoid any overlap with other contributors. This task will include implementing lexicographic type comparison using infer_binary_type_comparison.
@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Oct 9, 2024
@MichaReiser MichaReiser mentioned this issue Oct 9, 2024
Closed
13 tasks
@cake-monotone cake-monotone mentioned this issue Oct 11, 2024
Merged
carljm added a commit that referenced this issue Oct 16, 2024
@cake-monotone @carljm
[red-knot] Implement Type::Tuple Comparisons (#13712)
2ffc3fa 
## Summary

This PR implements comparisons for (tuple, tuple).

It will close #13688 and complete an item in #13618 once merged.

## Test Plan

Basic tests are included for (tuple, tuple) comparisons.

---------

Co-authored-by: Carl Meyer <carl@astral.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cake-monotone cake-monotone

Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[red-knot] Implement Type::Tuple Comparisons cake-monotone/ruff
2 participants
@cake-monotone @dhruvmanila