Fork when minimum Python version increases #8628
Merged
+131
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/fork
branch
from
4c3d6a6
to
f562f47
Compare
charliermarsh
commented
Oct 28, 2024
Comment on lines
+2833
to
2842
| { | ||
| let dep = deps.pop().unwrap(); | ||
| let markers = dep.package.marker().cloned().unwrap_or(MarkerTree::TRUE); | ||
| for fork in &mut forks { | ||
| if !fork.markers.is_disjoint(&markers) { | ||
| fork.dependencies.push(dep.clone()); | ||
| } | ||
| } | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This is just indented. The only change is the extra condition.
konstin
approved these changes
Oct 28, 2024
BurntSushi
approved these changes
Oct 28, 2024
| /// | ||
| /// This should resolve successfully, but currently fails [1]. | ||
| /// | ||
| /// [1]: https://github.com/astral-sh/uv/issues/4668 |
zanieb
approved these changes
Oct 28, 2024
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a re-implementation of #4712, though is now seemingly much simpler. This issue keeps coming up, and users have a workaround with
tool.uv.environments, but it's really a bug in the resolver.Closes #4668.