-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork when minimum Python version increases #8628
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7989,10 +7989,6 @@ fn universal_requires_python() -> Result<()> { | |
} | ||
|
||
/// Perform a universal resolution that requires narrowing the supported Python range in a non-fork. | ||
/// | ||
/// This should resolve successfully, but currently fails [1]. | ||
/// | ||
/// [1]: https://github.com/astral-sh/uv/issues/4668 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! |
||
#[test] | ||
fn universal_requires_python_incomplete() -> Result<()> { | ||
let context = TestContext::new("3.12"); | ||
|
@@ -8006,15 +8002,17 @@ fn universal_requires_python_incomplete() -> Result<()> { | |
.arg("-p") | ||
.arg("3.7") | ||
.arg("--universal"), @r###" | ||
success: false | ||
exit_code: 1 | ||
success: true | ||
exit_code: 0 | ||
----- stdout ----- | ||
# This file was autogenerated by uv via the following command: | ||
# uv pip compile --cache-dir [CACHE_DIR] requirements.in -p 3.7 --universal | ||
uv==0.1.24 ; python_full_version >= '3.8' | ||
# via -r requirements.in | ||
|
||
----- stderr ----- | ||
warning: The requested Python version 3.7 is not available; 3.12.[X] will be used to build dependencies instead. | ||
× No solution found when resolving dependencies: | ||
╰─▶ Because only uv{python_full_version >= '3.8'}<=0.1.24 is available and the requested Python version (>=3.7) does not satisfy Python>=3.8, we can conclude that all versions of uv{python_full_version >= '3.8'} are incompatible. | ||
And because you require uv{python_full_version >= '3.8'}, we can conclude that your requirements are unsatisfiable. | ||
Resolved 1 package in [TIME] | ||
"### | ||
); | ||
|
||
|
@@ -12410,7 +12408,7 @@ fn prune_unreachable() -> Result<()> { | |
----- stdout ----- | ||
# This file was autogenerated by uv via the following command: | ||
# uv pip compile --cache-dir [CACHE_DIR] requirements.in --universal -p 3.7 | ||
argcomplete==3.1.2 ; python_full_version >= '3.8' | ||
argcomplete==3.2.3 ; python_full_version >= '3.8' | ||
# via -r requirements.in | ||
|
||
----- stderr ----- | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just indented. The only change is the extra condition.