Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

MNT: Appveyor no longer supported #464

Merged
merged 2 commits into from
Oct 21, 2020
Merged

MNT: Appveyor no longer supported #464

merged 2 commits into from
Oct 21, 2020

Conversation

pllim
Copy link
Member

@pllim pllim commented Oct 20, 2020

As @astrofrog suggested in #462 (comment) .

Fix #454, close #393, close #350, close #346

Out of scope: Update outdated Travis instructions.

@pllim pllim added the appveyor label Oct 20, 2020
@pllim pllim requested review from astrofrog and bsipocz October 20, 2020 20:37
``.travis.yml`` and ``appveyor.yml`` files of astropy packages for the
[Travis](https://travis-ci.org) and [AppVeyor](https://www.appveyor.com/)
services respectively.
``.travis.yml`` file of Astropy packages for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not just astropy any more, but a more broad range

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggested wording? 😸

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not picky on words, and was just nitpicking. In fact, lets get this merged now rather than have another CI round.
If we get bored, we can always come back and reword the readme here and possibly elsewhere, too, as it got written in a very organic way.

A more useful thing would be through to let the batchpr/issue bot loose on all the packages still using the ci-helpers appveyor, and let them know that things got evolved, they better evolve, too.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
@bsipocz bsipocz merged commit 4da2624 into astropy:master Oct 21, 2020
@bsipocz
Copy link
Member

bsipocz commented Oct 21, 2020

Thanks @pllim!

@astrofrog
Copy link
Member

Thanks @pllim! Maybe it would be worth emailing astropy-dev as a heads up?

@pllim pllim deleted the retire-appveyor branch October 21, 2020 13:22
@pllim
Copy link
Member Author

pllim commented Oct 21, 2020

Thanks for the review, you two!

https://groups.google.com/g/astropy-dev/c/oP0OT3b0Jmk

@pllim
Copy link
Member Author

pllim commented Oct 21, 2020

Did a quick search and got 181 results. 😲

https://github.com/search?q=%22astropy%2Fci-helpers%22+in%3Afile+filename%3Aappveyor.yml

This was referenced Oct 29, 2020
@pllim
Copy link
Member Author

pllim commented Oct 29, 2020

I opened issues to the repos I could find but sure I have missed some. Ah, well.

Getting the repo list was a bit tricky, as I couldn't get PyGithub, github3.py, or GitHub v4 GraphQL to work. This worked though (max is 100 per page, so needed 2 pages):

curl -o searchresults1.json -u user:token -H "Accept: application/vnd.github.v3+json" "https://api.github.com/search/code?q=\"astropy%2Fci-helpers\"+in%3Afile+filename%3Aappveyor.yml&page=1&per_page=100&sort=indexed&order=desc"

curl -o searchresults2.json -u user:token -H "Accept: application/vnd.github.v3+json" "https://api.github.com/search/code?q=\"astropy%2Fci-helpers\"+in%3Afile+filename%3Aappveyor.yml&page=2&per_page=100&sort=indexed&order=desc"

176 repos listed after removing a few duplicates.

168 repos left after ignoring forks and archived ones.

I did something like this (not the most polished but good enough for one-time use). Cannot trust the search results completely, so have to do additional checks.

from time import sleep

# flist is a list of Repository objects from PyGithub
# helper is the issue opener from batchpr

for repo in flist: 
    sleep(1) 
    try: 
        contents = repo.get_contents('appveyor.yml')   # Had to repeat this for .appveyor.yml, manually caught one Appveyor.yml
    except Exception as e: 
        print(repo.full_name, str(e)) 
        continue
    lines = contents.decoded_content.decode('utf-8').split('\n') 
    found = False 
    for line in lines: 
        if 'astropy/ci-helpers' in line and not line.startswith('#'): 
            found = True 
            break 
    if not found: 
        print(repo.full_name, 'no astropy/ci-helpers in file') 
        continue 
    print('*********', repo.full_name) 
    helper.run(repo.full_name)

@bsipocz
Copy link
Member

bsipocz commented Oct 29, 2020

Thank you @pllim! I have the feeling we had a solution to find these repos, but even if it's true it's certainly outdated by now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants