Support attach-point in addition to data-attach-point, fixes ibm-js#175.

asudoh · May 2, 2016 · 2832a6f · 2832a6f
1 parent c501771
commit 2832a6f
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 3 deletions.
diff --git a/delite/createRenderer.js b/delite/createRenderer.js
@@ -55,8 +55,8 @@ define([
 				template._instanceData = this.instanceData;
 			}
 			this.own(template.instantiate(this).insertBefore(this))[0].content;
-			forEach.call(this.querySelectorAll("[data-attach-point]"), function (elem) {
-				var value = elem.getAttribute("data-attach-point");
+			forEach.call(this.querySelectorAll("[attach-point],[data-attach-point]"), function (elem) {
+				var value = elem.getAttribute("attach-point") || elem.getAttribute("data-attach-point");
 				if (value) {
 					this[value] = elem;
 				}

diff --git a/tests/delite/createRenderer.js b/tests/delite/createRenderer.js
@@ -20,6 +20,7 @@ define([
 	"../../delite/createRenderer!./templates/nestedWidgetTemplate.html",
 	"../../delite/createRenderer!./templates/complexAttributeTemplate.html",
 	"../../delite/createRenderer!./templates/attachPointTemplate.html",
+	"../../delite/createRenderer!./templates/dataAttachPointTemplate.html",
 	"../../delite/createRenderer!./templates/simpleWithAlternateBindingTemplate.html",
 	"../../delite/createRenderer!../templates/eventTemplate.html",
 	"deliteful/StarRating",
@@ -47,6 +48,7 @@ define([
 	renderNestedWidgetTemplate,
 	renderComplexAttributeTemplate,
 	renderAttachPointTemplate,
+	renderDataAttachPointTemplate,
 	renderAlternateBindingTemplate,
 	renderEventsTemplate
 ) {
@@ -91,6 +93,10 @@ define([
 					render: renderAttachPointTemplate,
 					baseClass: "liaison-test-attachpoint"
 				}),
+				DataAttachPointTemplateWidget = register("liaison-test-dataattachpoint", [HTMLElement, Widget], {
+					render: renderDataAttachPointTemplate,
+					baseClass: "liaison-test-dataattachpoint"
+				}),
 				AlternateBindingTemplateWidget = register("liaison-test-alternatebinding", [HTMLElement, Widget], {
 					render: renderAlternateBindingTemplate,
 					baseClass: "liaison-test-alternatebinding",
@@ -523,6 +529,20 @@ define([
 					expect(w.valueNode).to.equal(w.querySelector("input"));
 				});
 			});
+			it("Attach point with alternate attribute name", function () {
+				var w = new DataAttachPointTemplateWidget().placeAt(document.body);
+				this.timeout = 10000;
+				handles.push({
+					remove: function () {
+						w.destroy();
+					}
+				});
+				return waitFor(function () {
+					return w.valueNode;
+				}).then(function () {
+					expect(w.valueNode).to.equal(w.querySelector("input"));
+				});
+			});
 			it("Simple binding with default alternate binding factory", function () {
 				var w = new AlternateBindingTemplateWidget({
 						first: "John"

diff --git a/tests/delite/templates/attachPointTemplate.html b/tests/delite/templates/attachPointTemplate.html
@@ -1 +1 @@
-<input data-attach-point="valueNode">
+<input attach-point="valueNode">
diff --git a/tests/delite/templates/dataAttachPointTemplate.html b/tests/delite/templates/dataAttachPointTemplate.html
@@ -0,0 +1 @@
+<input data-attach-point="valueNode">