Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-attach-point is not consistent with handlebar template #175

Open
nguyenanduong opened this issue Apr 20, 2016 · 0 comments
Open

data-attach-point is not consistent with handlebar template #175

nguyenanduong opened this issue Apr 20, 2016 · 0 comments

Comments

@nguyenanduong
Copy link

With a handlebar template, we can attach an element with attach-point attribute. However, in liaison, the attribute name is data-attach-point. That makes it a little bit inconsistent.
asudoh added a commit to asudoh/liaison that referenced this issue Apr 21, 2016
@asudoh
s/data-attach-point/attach-point/g, fixes ibm-js#175.
62037a3
asudoh added a commit to asudoh/liaison that referenced this issue May 2, 2016
@asudoh
Support attach-point in addition to data-attach-point, fixes ibm-js#175.
2832a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nguyenanduong