fix stale props being passed to promiseFn when using watchFn

[salolivares]

Description

When watching for a variable changes using watchFn, the react async hook properly re-runs promiseFn but with old props passed in. This fix aims to correct that behavior.

This fixes #180

Checklist

Make sure you check all the boxes. You can omit items that are not applicable.

• Ensure promiseFn receives updated props.
• Added / updated the unit tests

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dffd39f:

Sandbox	Source
hungry-black-jevs3	Configuration
falling-sea-ynzsy	Issue #180

[codecov]

Codecov Report

Merging #181 into next will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #181      +/-   ##
==========================================
+ Coverage   98.58%   98.73%   +0.14%     
==========================================
  Files           8        8              
  Lines         424      395      -29     
  Branches      148      143       -5     
==========================================
- Hits          418      390      -28     
+ Misses          6        5       -1

Impacted Files	Coverage Δ
packages/react-async/src/useAsync.js	100% <100%> (ø)
packages/react-async/src/helpers.tsx
packages/react-async/src/reducer.ts
packages/react-async/src/Async.tsx
packages/react-async/src/propTypes.ts
packages/react-async/src/status.ts
packages/react-async/src/useAsync.tsx
packages/react-async/src/Async.js	100% <0%> (ø)
packages/react-async/src/status.js	100% <0%> (ø)
packages/react-async/src/propTypes.js	100% <0%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf5211...dffd39f. Read the comment docs.

[salolivares]

Another solution is to add lastOptions.current = options before the load() on line 135.

[Jyrno42]

Any chance to get this released soon?

[ghengeveld]

Thanks for reminding me. We were focused on the TypeScript migration, but that's merged now. This is looking good, so it's going out with the next release, which will be sometime this week.

[ghengeveld]

@all-contributors Please add @salolivares for code

[allcontributors]

@ghengeveld

I've put up a pull request to add @salolivares! 🎉

[ghengeveld]

@all-contributors Please add @salolivares for bug

[allcontributors]

@ghengeveld

I've put up a pull request to add @salolivares! 🎉

[ghengeveld]

@Jyrno42 I published a pre-release here: v10.0.0-alpha.0