Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v10 #214

Merged
merged 253 commits into from
Dec 2, 2019
Merged

Release v10 #214

merged 253 commits into from
Dec 2, 2019

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 21, 2019

This is a major release due to the migration to TypeScript. While technically it shouldn't change anything, it might be a breaking change in certain situations. Theres also a bugfix for watchFn and a fix for legacy browsers.

Thanks to @Avi98, @FredKSchott and @rokoroku for reviewing and helping out.

I published a pre-release here: v10.0.0-alpha.0

@ghengeveld ghengeveld self-assigned this Nov 21, 2019
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97b04ae:

Sandbox Source
youthful-visvesvaraya-3yz8r Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 21, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c78dfea:

Sandbox Source
reverent-frost-71t5l Configuration

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.14%.
The diff coverage is 98.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   98.72%   98.58%   -0.15%     
==========================================
  Files           8        8              
  Lines         393      424      +31     
  Branches      143      148       +5     
==========================================
+ Hits          388      418      +30     
- Misses          5        6       +1
Impacted Files Coverage Δ
packages/react-async/src/propTypes.ts 100% <ø> (ø)
packages/react-async-devtools/src/index.js 94.73% <100%> (ø) ⬆️
packages/react-async/src/helpers.tsx 100% <100%> (ø)
packages/react-async/src/status.ts 100% <100%> (ø)
packages/react-async/src/Async.tsx 100% <100%> (ø)
packages/react-async/src/reducer.ts 94.11% <94.11%> (ø)
packages/react-async/src/useAsync.tsx 99.23% <99.23%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43698be...c78dfea. Read the comment docs.

phryneas
phryneas previously approved these changes Nov 24, 2019
Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#181 and #175 look good to me - and I've been over #105 like 10 times now, so I'd say this is good to go 👍

@ghengeveld
Copy link
Member Author

This is currently blocked on failing tests for DevTools. For some reason it can't find ActionTypes. Most likely this is just a yarn link issue or something with TypeScript. @phryneas can you take a look?

Another issue is with the react dependency resolution script. At least on my local machine it can't find jq even though node-jq is installed and I end up with an empty package.json. Perhaps we should consider moving the forwards & backwards testing to a separate CI step, so that we have a clean workspace every time.

@ghengeveld
Copy link
Member Author

I fixed the ActionTypes problem, apparently we had to bump the version of react-async in the devDeps of the root package.

@phryneas
Copy link
Member

Another issue is with the react dependency resolution script. At least on my local machine it can't find jq even though node-jq is installed and I end up with an empty package.json. Perhaps we should consider moving the forwards & backwards testing to a separate CI step, so that we have a clean workspace every time.

That sounds like a good idea - would also bring the build time down due to parallelization.

@ghengeveld
Copy link
Member Author

ghengeveld commented Nov 24, 2019

I think we should move the back/forward tests to GitHub Actions. The rest can stay as it is.

@Khartir Khartir mentioned this pull request Nov 30, 2019
2 tasks
@ghengeveld ghengeveld merged commit 5a7cee9 into master Dec 2, 2019
@ghengeveld ghengeveld deleted the release branch December 2, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants